Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sopel 8 upgrade guide #46

Merged
merged 1 commit into from
May 27, 2024
Merged

Sopel 8 upgrade guide #46

merged 1 commit into from
May 27, 2024

Conversation

dgw
Copy link
Member

@dgw dgw commented Feb 23, 2024

It's time that this branch had a PR, so other maintainers can give feedback on the upgrade guide ahead of release. Draft for now; goodness knows the history already needs cleanup, and it will need even more after review(s).

@dgw dgw added the content label Feb 23, 2024
@dgw dgw added this to the Sopel 8.0.0 milestone Feb 23, 2024
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

_upgrading/sopel-8.md Outdated Show resolved Hide resolved
Copy link
Contributor

@SnoopJ SnoopJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sharing some long-overdue feedback, most of it authored in December for an earlier draft that was similar to this.

Even though I have some requested changes, I'm approving this as-is, because clearly none of my feedback is so important that it couldn't wait several months. At this point, our best feedback will probably come from users, and we just want to get 8.0 out the door.

_upgrading/sopel-8.md Outdated Show resolved Hide resolved
_upgrading/sopel-8.md Outdated Show resolved Hide resolved
_upgrading/sopel-8.md Outdated Show resolved Hide resolved
_upgrading/sopel-8.md Outdated Show resolved Hide resolved
_upgrading/sopel-8.md Outdated Show resolved Hide resolved
_upgrading/sopel-8.md Outdated Show resolved Hide resolved
_upgrading/sopel-8.md Show resolved Hide resolved
_upgrading/sopel-8.md Outdated Show resolved Hide resolved
_upgrading/sopel-8.md Outdated Show resolved Hide resolved
_upgrading/sopel-8.md Show resolved Hide resolved
_upgrading/sopel-8.md Outdated Show resolved Hide resolved
_upgrading/sopel-8.md Outdated Show resolved Hide resolved
_upgrading/sopel-8.md Outdated Show resolved Hide resolved
@dgw dgw marked this pull request as ready for review April 14, 2024 17:28
_upgrading/sopel-8.md Outdated Show resolved Hide resolved
_upgrading/sopel-8.md Outdated Show resolved Hide resolved
_upgrading/sopel-8.md Outdated Show resolved Hide resolved
_upgrading/sopel-8.md Outdated Show resolved Hide resolved
_upgrading/sopel-8.md Outdated Show resolved Hide resolved
_upgrading/sopel-8.md Outdated Show resolved Hide resolved
_upgrading/sopel-8.md Outdated Show resolved Hide resolved
_upgrading/sopel-8.md Outdated Show resolved Hide resolved
_upgrading/sopel-8.md Outdated Show resolved Hide resolved
_upgrading/sopel-8.md Outdated Show resolved Hide resolved
_upgrading/sopel-8.md Outdated Show resolved Hide resolved
_upgrading/sopel-8.md Outdated Show resolved Hide resolved
@dgw
Copy link
Member Author

dgw commented Apr 21, 2024

@half-duplex Bunch of changes pushed up in response to your feedback 😸

@dgw dgw requested a review from half-duplex April 21, 2024 23:24
_upgrading/sopel-8.md Outdated Show resolved Hide resolved
The result of lengthy collaboration. Commit metadata does not *quite*
reflect the actual authorship timeline... ;-)

Co-authored-by: James <[email protected]>
Co-authored-by: mal <[email protected]>
@dgw
Copy link
Member Author

dgw commented Apr 27, 2024

Seeing no further objections (feedback), I have started getting this ready to merge.

Will most likely create a new PR to hold all of the 8.0-related updates and test integrating all the different parts (upgrade guide, updated submodule docs, updated redirects, etc.) before final merge.

@dgw
Copy link
Member Author

dgw commented Apr 28, 2024

Current status: Trying to convince Netlify that it should actually show the deploy log so I have a chance to fix whatever went wrong after pulling in sopel-irc/sopel#2606 to test the new docs. It gets stuck like this and never loads the log:

image


Edit: On a fresh branch that only touches _sopel/, it still fails. Was able to get the logs in a different browser but they are not helpful. It doesn't show any of the build script's output, only a non-zero exit code:

7:05:13 PM: Failed during stage 'building site': Build script returned non-zero exit code: 2 (https://ntl.fyi/exit-code-2)

image

I will revert this branch to the known-working upgrade guide and continue debugging _sopel/ in a new PR.

@dgw dgw changed the base branch from master to 8.0-release-integration May 27, 2024 00:29
@dgw
Copy link
Member Author

dgw commented May 27, 2024

Base branch changed to #47. I will most likely revert the test-merge of #38 there and perform a manual three-way merge of both PRs into the integration branch/PR—hoping that it goes well.

@dgw dgw force-pushed the 8.0-release-integration branch from f9ba9e9 to a74fa39 Compare May 27, 2024 00:39
@dgw dgw merged commit 38f30e0 into 8.0-release-integration May 27, 2024
4 checks passed
@dgw dgw deleted the upgrade-to-sopel-8 branch May 27, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants