Add buttons to alert on shortcut taken by system to allow user to use it anyway #125
Conversation
|
@sindresorhus Could you please merge this one? |
| for: self.window, | ||
| title: "keyboard_shortcut_used_by_system".localized, | ||
| // TODO: Add button to offer to open the relevant system settings pane for the user. | ||
| message: "keyboard_shortcuts_can_be_changed".localized | ||
| message: "keyboard_shortcuts_can_be_changed".localized, | ||
| buttonTitles: [ |
There was a problem hiding this comment.
The first item should be OK, the second item should be Use Anyway, since the default choice should be OK.
There was a problem hiding this comment.
Hi @sindresorhus, I'm a great fan of your work. Using many of the projects you released for the apps I'm working on – thanks.
I had a quick look at the Apple HIG on this, and this example on alerts is the closest I could get to.
So things boil down to what the primary choice would be in this situation.
My rationale for the order of the buttons, which I think fits with what's outlined in the HIG, is: a 'cancel' action at the left (or bottom now?) for the user to go back and re-take an action, or a 'go ahead' action at the right (or top?) for her to proceed with the choice, having digested the message in the dialog. I.e. 'go ahead' should be the primary action.
So I think that, even if the action were to be interpreted as strongly inadvisable, the button to go ahead should be the first one. Else, the default choice would be to cancel the action, which I can't remember to be the order of choices in alerts I've seen.
I'm happy to be proven wrong with any example alert available in a recent version of macOS though!
There was a problem hiding this comment.
In this case, the primary button should be "OK." The primary button should represent the default, recommended, or most likely action that users would take. Since "Use Anyway" is not recommended, it should not be the primary button. Making "OK" the primary button will help guide users towards the safer and more desirable action. This follows user interface design best practices, which prioritize guiding users to make the right decisions and avoid potential issues.
This one is closer to ours:
|
You also need to fix the lint warning. |
|
Let me know where I can see these lint errors and I'd be happy to fix them. |
| @@ -3,3 +3,4 @@ | |||
| "keyboard_shortcut_used_by_menu_item" = "This keyboard shortcut cannot be used as it’s already used by the “%@” menu item."; | |||
| "keyboard_shortcut_used_by_system" = "This keyboard shortcut cannot be used as it’s already a system-wide keyboard shortcut."; | |||
| "keyboard_shortcuts_can_be_changed" = "Most system-wide keyboard shortcuts can be changed in “System Settings › Keyboard › Keyboard Shortcuts”."; | |||
| "force_use_shortcut" = "Use Anyway"; | |||
There was a problem hiding this comment.
| "force_use_shortcut" = "Use Anyway"; | |
| "force_use_shortcut" = "Use Anyway"; | |
|
Bump |
Fixes issue #33 (assuming it didn't cover the 'used by menu item' case)