Allow overriding system-reserved shortcuts #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tofumatt
commented
Oct 26, 2023
|
What keyboard combination do you use to test the dialog (to trigger it)? |
|
I used "Command + Escape", which is actually my usual keyboard shortcut for an app I'm transitioning to use |
Repository owner
deleted a comment from
chatobn
Jan 22, 2024
Repository owner
deleted a comment from
chatobn
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #33.
Updated version of #125 with the linting errors fixed, and "OK" as the default option in the dialog.
Works as-expected in my app:
CleanShot.2023-10-26.at.11.31.08.mp4