Add Scala 2.13 support #353
Conversation
This is the first version to support 2.13. Source: https://mvnrepository.com/artifact/org.scalariform/scalariform
This is the latest version of 3.0.X to support 2.13. Source: https://mvnrepository.com/artifact/org.scalatest/scalatest NOTE: I did not go to 3.1.0 because it required further changes to dependencies. This minimizes risk.
Scalatest 3.0.8 deprecated this package.
JavaConversions was removed in 2.13.
This is removed in 2.13 and doesn't appear used in any other builds
Apparently in 2.13 ListBuffer are no longer Seq. Given that they rewrote the collections library, this doesn't surprise me.
Example error: [error] /Users/chris/git/github/scalastyle/scalastyle/src/main/scala/org/scalastyle/scalariform/ProcedureDeclarationChecker.scala:24: `Unit` companion object is not allowed in source; instead, use `()` for the unit value [error] protected def matchParameters() = Unit [error]
Removed in 2.13. JavaConverters works well though
Codecov Report
@@ Coverage Diff @@
## master #353 +/- ##
=====================================
Coverage 0% 0%
=====================================
Files 62 62
Lines 1495 1497 +2
Branches 146 152 +6
=====================================
- Misses 1495 1497 +2
Continue to review full report at Codecov.
|
|
Thanks for making it work for 2.13! I'm afraid though it's quite unlikely you will get these changes merged and released since this project hasn't been maintained for a long time now - see #327. You're probably more likely to get this released by opening this PR against @BardurArantsson's fork here, although I'm not sure if he's willing to maintain it or his fork was just a one off to make a more recent release for himself (there hasn't been any other activity in that fork since Sept). |
|
@mwz Unfortunately aware (many of the open PRs and issues are my coworkers.) This was mostly a hopeful PR. 🤞 Likely what we'll do is fork this and maintain it ourselves publicly (I'll post a link if/when that happens), or we'll switch to another tool for the same. The good news is this isn't a time-pressing issue for us right now. |
|
Hey @cddude229, I've pulled your changes into my fork and made a release. |
+ testpasses for all versions. Each commit could be merged by itself (i.e.+ testpasses for all previous versions.)