[vdobj] give each thread its own activeCommand #2345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saulpw
reviewed
Mar 11, 2024
visidata/vdobj.py
Outdated
| def activeCommand(self, value): | ||
| self.setThreadActiveCommand(threading.current_thread(), value) | ||
|
|
||
| def setThreadActiveCommand(self, thread, value): |
There was a problem hiding this comment.
If no one else uses this function, let's merge it into the activeCommand setter.
There was a problem hiding this comment.
Yes, that's the only place it was used. I left the thread-specifying setter there in case we wanted to call it explicitly in _with_active_cmd for clarity. Because as I have it now, it is a bit strange to see cmd = vd.activeCommand and then, two lines later if cmd: vd.activeCommand = cmd.
I've merged it.
There was a problem hiding this comment.
I see what you mean. We'll add a comment there referring to this issue/PR.
saulpw
approved these changes
Mar 11, 2024
midichef
force-pushed
the
active_command
branch
from
c45d054
to
7ca6923
Compare
anjakefala
force-pushed
the
active_command
branch
from
8394483
to
c4f919e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2266.
a simple repro for #2266: open a large sheet and delete a large number of rows:
seq 1222333 |vdthengsgdU. The rows don't come back.