[statusbar-] move sheet.longname into vd object #2186
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Immediately after moving to a new sheet, the
sheet.longname
in the statusbar is incorrect. On the latest 3.0dev as well as 2.11.1.For example, right after
sheets-stack
, the longname displayed is blank. That's because the new sheet'ssheet.longname
is''
. Then if we quit out of that sheet withq
, the longname shown in the original sheet is incorrect. I expect it to show"quit-sheet"
, but instead it shows"sheets-stack"
, the name of last command executed in the original sheet.This PR moves
longname
into the vd object, instead of storing it in each sheet. Will this work?And is it safe to remove
BaseSheet.longname
?I think it's now obsolete but it's possible I missed a use somewhere.