[3006.x] Allow configuring firewall on non-English versions of Windows #66424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
s0undt3ch
approved these changes
May 14, 2024
| raise CommandExecutionError("LGPO NETSH: An unknown error occurred") | ||
|
|
||
| # Remove the junk | ||
| for setting in list(settings.keys()): |
There was a problem hiding this comment.
Suggested change
| for setting in list(settings.keys()): | |
| for setting in list(settings): |
This is enough, not blocking merge because of it though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allows Salt to configure the firewall on non-Windows systems. This replaces
netshwith theSet-NetFireWallProfilepowershell command under the hood. The function definitions and returns remain the same.What issues does this PR fix or reference?
Fixes #61534
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes