Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Unable to configure Windows Firewall policy on Non-English systems #61534

Closed
twangboy opened this issue Jan 27, 2022 · 2 comments
Closed
Assignees
Labels
Bug broken, incorrect, or confusing behavior Execution-Module State-Module Windows

Comments

@twangboy
Copy link
Contributor

twangboy commented Jan 27, 2022

Description
Unable to configure Windows Firewall policy on Non-English systems

https://bugzilla.eng.vmware.com/show_bug.cgi?id=2908191

The current method shells out to the netsh command line utility. The returns are localized depending on the language of the systems so we cannot guarantee English.

>netsh advfirewall show allprofiles

Configuración de Perfil de dominio:
----------------------------------------------------------------------
Estado                                ACTIVAR
Directiva de firewall                 BlockInbound,AllowOutbound
LocalFirewallRules                    N/A (solo almacén de GPO)
LocalConSecRules                      N/A (solo almacén de GPO)
InboundUserNotification               Deshabilitar
RemoteManagement                      Deshabilitar
UnicastResponseToMulticast            Habilitar
 
Registro:
LogAllowedConnections                 Deshabilitar
LogDroppedConnections                 Deshabilitar
FileName                              %systemroot%\system32\LogFiles\Firewall\pfirewall.log
MaxFileSize                           4096

I've tried changing the codepage but it does not change the output.

Perhaps we can use some .NET libraries to set Windows Firewall instead of shelling out.

Steps to Reproduce the behavior
Configure firewall policy on a Spanish system

Expected behavior
You should be able to configure firewall policy

Versions Report

salt --versions-report (Provided by running salt --versions-report. Please also mention any differences in master/minion versions.)
3002+
@twangboy twangboy added Bug broken, incorrect, or confusing behavior needs-triage labels Jan 27, 2022
@twangboy twangboy assigned twangboy and unassigned dwoz Jan 27, 2022
@twangboy twangboy added this to the Approved milestone Jan 27, 2022
@twangboy twangboy modified the milestones: Approved, Phosphorus v3005.0 Jan 28, 2022
@twangboy twangboy added the Sulfur v3006.0 release code name and version label Mar 1, 2022
@waynew waynew removed the Sulfur v3006.0 release code name and version label Dec 16, 2022
@twangboy
Copy link
Contributor Author

This should be fixed by #66424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior Execution-Module State-Module Windows
Projects
None yet
Development

No branches or pull requests

3 participants