New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Unit and Integration tests for MongoDBAtlasVectorSearch #12854
Adds Unit and Integration tests for MongoDBAtlasVectorSearch #12854
Conversation
…o get llama-index-embeddings-openai which is required for tests
…ndency. only -core is required
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this just be in the readme instead?
Hi @logan-markewich Is there anything further that you'd like on this? |
@caseyclements I'd like to merge, but I think we still need to account for skipping tests properly that rely on API keys, since those keys are not present in CICD |
Signed-off-by: Casey Clements <[email protected]>
…GODB_URI is not present Signed-off-by: Casey Clements <[email protected]>
Head branch was pushed to by a user without write access
@logan-markewich I've updated to skip tests. Would you please approve the workflows to check whether this fixes all remaining failures? This means that the tests stay in this repo, but the full Atlas integration tests are actually run in our CI. I'm happy with that. To install an Atlas local deployment for each workflow might be a big burden on your CI. Curiously, what do you do to test OpenAIEmbedding? |
@caseyclements tbh the tests on openai are lacking. Ideally the API response from the underlying openai client is mocked. |
@logan-markewich What was the intention of commit 1f22c8a? The tests now fail because only the sample text contains only a single node.
|
@caseyclements pants is annoying as hell to configure to rely on external files like text files. Easier to just use something in memory |
@logan-markewich Suppose we create an example that creates a |
Signed-off-by: Casey Clements <[email protected]>
@logan-markewich I just updated type hinting for backward compatibility to python 3.8. Would you please run the workflows? |
Took the time to fix the integration tests, and inserted many docs by splitting by newline. Should be good to go |
Description
This PR adds tests of the MongoDB vector store
MongoDBAtlasVectorSearch
. We have already begun to use these tests in our own continuous integration. This will allow us to maintain the package as llama-index main branch changes.New Package?
NO.
Did I fill in the
tool.llamahub
section in thepyproject.toml
and provide a detailed README.md for my new integration or package?YES
A small change to pyproject.toml for the mongodb package has been added to permit testing.
Version Bump?
Did I bump the version in the
pyproject.toml
file of the package I am updating? (Except for thellama-index-core
package)Yes. Micro version changed. No API changed, as this was just tests, additional dev dependency added.
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist:
make format; make lint
to appease the lint gods