Add patch file to llama_index #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eplaced with trivial example Signed-off-by: Casey Clements <[email protected]>
caseyclements
added a commit
that referenced
this pull request
May 13, 2024
* Revert "Add patch file to llama_index as maintainer, hopefully temporarily, replaced with trivial example (#25)" This reverts commit 3781555. * llama_index now points to upstream main branch. Standarized naming of MONGODB_URI in run.sh Signed-off-by: Casey Clements <[email protected]> --------- Signed-off-by: Casey Clements <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add patch file to llama_index as maintainer, hopefully temporarily, replaced with trivial example.
See discussion in pull-request: run-llama/llama_index#12854
Maintainer did not want a dependency on a text file that was already in the repo! "pants is annoying as hell to configure to rely on external files like text files."
I will work with him to get a non-trivial test but in the meantime, this will run against inputs that have more than one "node".