Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UI for static components #6101

Merged
merged 6 commits into from Apr 25, 2024
Merged

Update UI for static components #6101

merged 6 commits into from Apr 25, 2024

Conversation

abey79
Copy link
Contributor

@abey79 abey79 commented Apr 24, 2024

What

This PR updates the UI to better display static components, including:

  • Components logged as static now have a different icon.
  • Components logged as static do not have any event displayed in the timeline (see below for possible follow-up work).
  • The "timeless" gutter in the timeline is gone.
  • The hover tooltip in the streams for static component now displays their content (timeful components have their content displayed on the corresponding event in the timeline).
  • All components now have a "logged time" displayed along their data (showing the actually logging time that was taken into consideration by the current LatestAt query). It shows <static> for static components. This appears both in the selection panel and in the hover tooltips.
  • In addition, data consistency information is displayed for static component (both tooltip and selection panel):
    • Warning (yellow) if multiple static logs were recorded (the data of previous logging event is overwritten and not recoverable from the datastore).
    • Error (red) if the static component has timeful stuff logged as well (albeit that data is not loss, it's not queryable and extremely likely an indication of user error).

Note: the included release checklist is nice to try the error/warning cases.

Screenshots

static + timeful error:
image

multi-static warning:
image

selection panel:
image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@abey79 abey79 added ui concerns graphical user interface include in changelog labels Apr 24, 2024
@teh-cmc teh-cmc self-requested a review April 25, 2024 07:14
Copy link
Member

@teh-cmc teh-cmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

crates/re_data_ui/src/component.rs Outdated Show resolved Hide resolved
crates/re_data_ui/src/component.rs Outdated Show resolved Hide resolved
crates/re_entity_db/src/entity_db.rs Show resolved Hide resolved
crates/re_entity_db/src/time_histogram_per_timeline.rs Outdated Show resolved Hide resolved
crates/re_entity_db/src/time_histogram_per_timeline.rs Outdated Show resolved Hide resolved
crates/re_time_panel/src/lib.rs Show resolved Hide resolved
@abey79 abey79 merged commit b6a5072 into main Apr 25, 2024
34 checks passed
@abey79 abey79 deleted the antoine/static-component-ui branch April 25, 2024 09:22
@nikolausWest
Copy link
Member

@abey79: question on this we never talked about. How do we report the opposite case where someone logged data as timeful first, and then logged as static (in which case I believe we are supposed to ignore the static call)?

@teh-cmc
Copy link
Member

teh-cmc commented Apr 26, 2024

(in which case I believe we are supposed to ignore the static call)

static data always take priority, irrelevant of what got logged first.

@abey79
Copy link
Contributor Author

abey79 commented Apr 26, 2024

Yeah. That piece of data would be displayed as a regular timeful thing, and as soon as the static log is ingested by the viewer, its back to the error/warning display of this PR.

@nikolausWest
Copy link
Member

static data always take priority, irrelevant of what got logged first.

Ok, great, well that keeps things simpler then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update UI for static component
3 participants