Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a better display of static components in the timeline #6102

Open
abey79 opened this issue Apr 24, 2024 · 0 comments
Open

Provide a better display of static components in the timeline #6102

abey79 opened this issue Apr 24, 2024 · 0 comments
Labels
ui concerns graphical user interface

Comments

@abey79
Copy link
Contributor

abey79 commented Apr 24, 2024

#6101 completely removed any data for static component in the timeline, but there is the opportunity of providing a better display there, including:

  • Some flat, full width indicator to signify that data exists (but no actual event). This is more consistent with a state (vs. event) view of data, so not super consistent with how other components are displayed.
  • If actual timeful event have occurred for a static component (which is an error condition), they could be conspicuously displayed to bring user attention.

This needs careful design though (and doesn't provide a massive value on top of the feedback already provided in the hover tooltip and the selection panel.

@abey79 abey79 added the ui concerns graphical user interface label Apr 24, 2024
abey79 added a commit that referenced this issue Apr 25, 2024
### What

This PR updates the UI to better display static components, including:
- Components logged as static now have a different icon.
- Components logged as static do not have any event displayed in the
timeline (see below for possible follow-up work).
- The "timeless" gutter in the timeline is gone.
- The hover tooltip in the streams for static component now displays
their content (timeful components have their content displayed on the
corresponding event in the timeline).
- All components now have a "logged time" displayed along their data
(showing the actually logging time that was taken into consideration by
the current LatestAt query). It shows `<static>` for static components.
This appears both in the selection panel and in the hover tooltips.
- In addition, data consistency information is displayed for static
component (both tooltip and selection panel):
- Warning (yellow) if multiple static logs were recorded (the data of
previous logging event is overwritten and not recoverable from the
datastore).
- Error (red) if the static component has timeful stuff logged as well
(albeit that data is not loss, it's not queryable and extremely likely
an indication of user error).

Note: the included release checklist is nice to try the error/warning
cases.

- Fixes #6074
- Possible follow-up #6102

### Screenshots

static + timeful error:
<img width="368" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/98c7f1c8-8cf0-4604-95b8-ab7291bd1c20">

multi-static warning:
<img width="334" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/4d8e7612-bb3e-4295-bbd1-f9ba0554ac2a">

selection panel:
<img width="295" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/a63178ed-adcc-434f-8425-3b22ba88d003">


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6101?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6101?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/6101)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui concerns graphical user interface
Projects
None yet
Development

No branches or pull requests

1 participant