Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2177] Migrate to Java 11 Syntax and Features #2183

Merged
merged 12 commits into from
Apr 27, 2024
Merged

[#2177] Migrate to Java 11 Syntax and Features #2183

merged 12 commits into from
Apr 27, 2024

Conversation

asdfghjkxd
Copy link
Contributor

@asdfghjkxd asdfghjkxd commented Apr 1, 2024 •
edited
Loading

Part of #2177

Proposed commit message

Our current codebase is written on Java 8, which is around 2
generations behind on the latest supported LTS version for Java.

Let's move to migrate our CI/CD from Java 8 to Java 11 first to prepare
for any upcoming changes in our syntax, APIs and features.

Other information

N/A

@asdfghjkxd asdfghjkxd changed the title Migrate CI/CD to Java 11 [#2177] Migrate to Java 11 Syntax and Features Apr 1, 2024
@ckcherry23 ckcherry23 requested review from a team and removed request for a team April 1, 2024 18:44
@asdfghjkxd asdfghjkxd mentioned this pull request Apr 2, 2024
Closed
1 task
sopa301
sopa301 reviewed Apr 2, 2024
View reviewed changes
Copy link
Contributor

@sopa301 sopa301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also update the docs, particularly the required Java version in the developer guide!

@supermii2
Copy link
Contributor

Adding on to what Ryan has mentioned, we should also consider upgrading checkstyle and other parts that can be done following the migration!

@asdfghjkxd
Copy link
Contributor Author

@sopa301 Done! I have updated the docs to reflect the migration from Java 8 to Java 11!

@asdfghjkxd
Copy link
Contributor Author

@supermii2 I agree, we should discuss the different components that can be upgraded and begin implementing the changes in this PR!

@asdfghjkxd asdfghjkxd mentioned this pull request Apr 4, 2024
Closed
4 tasks
sopa301
sopa301 approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@sopa301 sopa301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sopa301 sopa301 requested a review from a team April 4, 2024 13:05
@asdfghjkxd
Copy link
Contributor Author

@supermii2 I have upgraded checkstyle to version 10.10.0 as described in #1304. Do let me know if there are any other areas that need upgrading!

supermii2
supermii2 reviewed Apr 8, 2024
View reviewed changes
Copy link
Contributor

@supermii2 supermii2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ckcherry23
ckcherry23 reviewed Apr 13, 2024
View reviewed changes
build.gradle Outdated
toolVersion = '9.3'
toolVersion = '10.10.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better if we do the checkstyle upgrade in a different PR, because there may be some changes that break backward compatibility.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, sure thing, I will revert back to the previous commit before the introduction of the new checkstyle tool!

@asdfghjkxd
Revert "Update CI JDK version"
3bec826 
The updating of the Checkstyle tool will be deferred
to another PR to avoid causing dependency issues
arising from backwards compatibility.
@asdfghjkxd
Reapply "Update CI JDK version"
0445789 
Reapplying revert action as it was reverted on
the wrong commit.
@ckcherry23 ckcherry23 removed the request for review from sopa301 April 13, 2024 09:27
@asdfghjkxd
Revert "Update checkstyle tool"
5b1ca53 
The updating of the Checkstyle tool will be deferred
to another PR to avoid causing dependency issues
arising from backwards compatibility.
@ckcherry23 ckcherry23 removed the request for review from supermii2 April 13, 2024 09:27
ckcherry23
ckcherry23 approved these changes Apr 13, 2024
View reviewed changes
Copy link
Member

@ckcherry23 ckcherry23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ckcherry23 ckcherry23 requested a review from a team April 13, 2024 09:30
This was referenced Apr 15, 2024
Merged
Open
gok99
gok99 reviewed Apr 26, 2024
View reviewed changes
Copy link
Contributor

@gok99 gok99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really sorry for the review delays these last 2 weeks! Thanks for the thorough CI and docs updates. Looks most good to go!

Can we remove the killDescendants in serveTestReportInBackground at line 202 of build.gradle?

@asdfghjkxd asdfghjkxd requested a review from gok99 April 26, 2024 05:34
@asdfghjkxd
Copy link
Contributor Author

@gok99 I have removed the flag from the build.gradle file. Do let me know if there are any more changes that needs to be made!

gok99
gok99 approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@gok99 gok99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ckcherry23
Copy link
Member

Right now, the status checks are not passing because the branch protection rules require the "JDK 8" version to pass, whereas this PR changes the CI name to use "JDK 11".

Hence, the "Branch protection rules" or "Status checks that are required" settings must be updated to reflect the new name for this PR to be merged.

@chan-j-d
Copy link
Contributor

@ckcherry23 I've updated the branch protection rules to require the new JDK 11 checks instead. Though the frontend tests seem to be failing somewhat randomly, based on the history of CI runs on this PR. Should probably fix that soon and merge this as it breaks the other PRs.

@supermii2 supermii2 merged commit a25630e into reposense:master Apr 27, 2024
8 checks passed
@github-actions GitHub Actions
Copy link
Contributor

The following links are for previewing this pull request:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supermii2 supermii2 supermii2 left review comments

@gok99 gok99 gok99 approved these changes

@ckcherry23 ckcherry23 ckcherry23 approved these changes

@sopa301 sopa301 sopa301 approved these changes

@MarcusTXK MarcusTXK Awaiting requested review from MarcusTXK

Assignees
No one assigned
Labels
s.ToMerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@asdfghjkxd @supermii2 @ckcherry23 @chan-j-d @gok99 @sopa301