Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2170] Add Blurbs for Repos #2191

Merged
merged 30 commits into from
May 12, 2024

Conversation

asdfghjkxd
Copy link
Contributor

@asdfghjkxd asdfghjkxd commented Apr 15, 2024

Part of #2170

Proposed commit message

Currently, there are no ways for student developers to append messages
for each of the repositories they would like to showcase using
RepoSense.

Let's move to implement a blurbs feature to allow individual student
developers to showcase their contributions to their project.

Other information

This feature requires Java 11 CI/CD to be implemented.

@asdfghjkxd asdfghjkxd requested a review from a team April 15, 2024 05:58
Copy link
Contributor

@sopa301 sopa301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I like the formatting of the JSON files to make it easier to read. Is it possible to add a negative test case for the BlurbMap builder?

@sopa301 sopa301 requested a review from a team May 2, 2024 09:07
@asdfghjkxd
Copy link
Contributor Author

@sopa301 Let me work on that and update you in the upcoming days!

@asdfghjkxd asdfghjkxd requested a review from a team May 6, 2024 11:57
@asdfghjkxd
Copy link
Contributor Author

@sopa301 I have implemented new test cases for BlurbMap, please do let me know if there are any other aspects that are lacking in tests!

Copy link
Contributor

@sopa301 sopa301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@ckcherry23 ckcherry23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @asdfghjkxd and @sopa301!

Can you please also update the Customizing Reports page in the User Guide to explain how this feature can be used? Maybe it can be merged with the 'Add a title' section to be called 'Personalizing Reports', and the 2 personalization options can be mentioned underneath (titles and blurbs).

One more thing to note is that the current code is implemented such that blurbs can only be used for repos. In case we foresee adding blurbs for author groups (eg. CS3281 summary for a student) or just for repo-author pairs (eg. each CS2103T student mentions their contribution to the tP), then we can create a new issue for this. @damithc

build.gradle Outdated Show resolved Hide resolved
src/main/java/reposense/parser/MarkdownParser.java Outdated Show resolved Hide resolved
@ckcherry23 ckcherry23 requested review from a team May 11, 2024 16:45
Copy link
Member

@ckcherry23 ckcherry23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we restyle the blurb box to be more apparent? Right now, the grey color is too light.
Here are my suggestions:

  • Use #F6F8FA as the fill color
  • Use #E9EBEF as the border color
  • Use 1px for the border width
  • Use 4px for the border radius
  • Ensure the top padding is the same as the bottom padding when using a single line of plain text, which is the most common blurb content expected.

Current:
image

Suggested:
image

Also, it would be great if one of the @reposense/active-developers who did not contribute to this PR added their review too.

@ckcherry23 ckcherry23 requested a review from a team May 11, 2024 18:50
Copy link
Member

@ckcherry23 ckcherry23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The frontend and docs LGTM. Once the backend comments are addressed, this should be good to go.

@asdfghjkxd asdfghjkxd requested a review from a team May 12, 2024 11:54
@asdfghjkxd
Copy link
Contributor Author

@gok99 @ckcherry23 I have added the new changes as requested!

Copy link
Member

@ckcherry23 ckcherry23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @sopa301 and @asdfghjkxd for your sprinting efforts today to wrap up this PR!

@ckcherry23 ckcherry23 requested a review from a team May 12, 2024 12:03
Copy link
Contributor

@gok99 gok99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one final request before we can merge this.

@asdfghjkxd @sopa301 This is a really cool feaure and I'm excited to discuss how we can expand on this:

  • As discussed earlier, I think having blurbs for author / none grouped views (in addition to repository) would be quite useful. Perhaps one of you could create an issue to discuss this.
  • Including blurbs in the one-stop config. I think since the config is meant to provide key features for people interested in quickly showcasing their work, adding the blurbs will add a lot of value. However, having two sources of blurbs will introduce complications. We can discuss this further in One-Stop Config File for Code Portfolio #2161.

@ckcherry23 ckcherry23 requested a review from gok99 May 12, 2024 13:49
Copy link
Contributor

@gok99 gok99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the speedy work today

@ckcherry23 ckcherry23 merged commit f4cad78 into reposense:master May 12, 2024
8 checks passed
Copy link
Contributor

The following links are for previewing this pull request:

ckcherry23 added a commit that referenced this pull request May 12, 2024
@damithc
Copy link
Collaborator

damithc commented May 12, 2024

Thanks @asdfghjkxd for this PR, and @ckcherry23 @gok99 @sopa301 for the reviews/guidance. 💯

@ckcherry23
Copy link
Member

Hi prof @damithc, I merged the PR without giving co-author credit to @sopa301 by mistake, but both @asdfghjkxd and @sopa301 were authors of this PR.

@damithc
Copy link
Collaborator

damithc commented May 12, 2024

Hi prof @damithc, I merged the PR without giving co-author credit to @sopa301 by mistake, but both @asdfghjkxd and @sopa301 were authors of this PR.

Noted @ckcherry23 Thanks both @asdfghjkxd and @sopa301

@damithc
Copy link
Collaborator

damithc commented May 14, 2024

@asdfghjkxd @sopa301 Which folder should contain the blurbs.md?
I tried both assets and configs folders with this file, but couldn't get it to show up in the dashboard.

@sopa301
Copy link
Contributor

sopa301 commented May 14, 2024

Hi prof @damithc , the link should be the link to the branch instead of to the repo (because multiple branches from the same repo can be displayed). For example, https://github.com/AY2324S2-CS2103-F08-2/tp/tree/master instead of https://ay2324s2-cs2103-f08-2.github.io/tp/

If you want to configure the blurbs.md to point to the main/master branch if the repo link is specified, we can open an issue for it.

@damithc
Copy link
Collaborator

damithc commented May 14, 2024

Hi prof @damithc , the link should be the link to the branch instead of to the repo (because multiple branches from the same repo can be displayed). For example, https://github.com/AY2324S2-CS2103-F08-2/tp/tree/master instead of https://ay2324s2-cs2103-f08-2.github.io/tp/

@sopa301 Ah, I see. I missed that part. It's working now after I added the branch. Thanks for the clarification.

If you want to configure the blurbs.md to point to the main/master branch if the repo link is specified, we can open an issue for it.

I guess no need. It's not too much extra work to specify the branch.

@damithc
Copy link
Collaborator

damithc commented May 15, 2024

Feature in action https://nus-cs2103-ay2324s2.github.io/tp-dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants