Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2004] Remove redundant Segment class #2085

Merged
merged 4 commits into from
Jan 26, 2024
Merged

[#2004] Remove redundant Segment class #2085

merged 4 commits into from
Jan 26, 2024

Conversation

jonasongg
Copy link
Contributor

@jonasongg jonasongg commented Jan 20, 2024 •
edited
Loading

Fixes #2004

Proposed commit message

Remove Segment class, replace with AuthorshipFileSegment

The Segment class and AuthorshipFileSegment interface are equivalent in
their usage and their redundancy seems to be a remnant when the code
was migrated from JS to TS.

Let's remove the Segment class for consistency and to improve runtime
performance.

Other information

A very similar issue #1973 exists, but I decided against putting addressing both issues in the same PR. If it is better to address both (since they are both quite minor changes), let me know!

@jonasongg jonasongg requested a review from a team January 20, 2024 06:10
@jonasongg jonasongg self-assigned this Jan 20, 2024
@jonasongg jonasongg removed their assignment Jan 20, 2024
sopa301
sopa301 approved these changes Jan 20, 2024
View reviewed changes
Copy link
Contributor

@sopa301 sopa301 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should omit the full stop in the first line of the commit message if it is meant as the subject line.

I agree that #1973 should be done in a separate PR as these are related but parallel issues.

@jonasongg
Copy link
Contributor Author

@sopa301 Ah, thanks for spotting!

@sopa301 sopa301 requested a review from a team January 22, 2024 12:34
vvidday
vvidday approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@vvidday vvidday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Definitely agree with the call of addressing both issues in separate PRs (in line with our PR guidelines)

ckcherry23
ckcherry23 approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@ckcherry23 ckcherry23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first PR @jonasongg! LGTM!

@jonasongg jonasongg mentioned this pull request Jan 22, 2024
Merged
@ckcherry23 ckcherry23 merged commit eb7a944 into reposense:master Jan 26, 2024
10 checks passed
@github-actions GitHub Actions
Copy link
Contributor

The following links are for previewing this pull request:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vvidday vvidday vvidday approved these changes

@ckcherry23 ckcherry23 ckcherry23 approved these changes

@sopa301 sopa301 sopa301 approved these changes

Assignees
No one assigned
Labels
s.ToMerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicate interface and class for Segment
4 participants
@jonasongg @vvidday @ckcherry23 @sopa301