Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1973] Remove redundant User class #2093

Merged
merged 2 commits into from
Jan 26, 2024
Merged

[#1973] Remove redundant User class #2093

merged 2 commits into from
Jan 26, 2024

Conversation

jonasongg
Copy link
Contributor

@jonasongg jonasongg commented Jan 22, 2024 •
edited
Loading

Fixes #1973

Proposed commit message

Remove utils/user.ts, replace with User interface from types.ts

The User class and interface are equivalent in their usage and their
redundancy seems to be a remnant when the code was migrated from JS to
TS.

Let's remove the User class for consistency and to improve runtime
performance.

Other information

Similar to #2085.

@jonasongg jonasongg requested a review from a team January 22, 2024 16:24
sopa301
sopa301 approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@sopa301 sopa301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sopa301 sopa301 requested a review from a team January 22, 2024 16:51
ckcherry23
ckcherry23 approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@ckcherry23 ckcherry23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ckcherry23 ckcherry23 requested a review from a team January 22, 2024 18:40
MarcusTXK
MarcusTXK approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@MarcusTXK MarcusTXK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice job.

@ckcherry23 ckcherry23 merged commit 6481806 into reposense:master Jan 26, 2024
10 checks passed
@github-actions GitHub Actions
Copy link
Contributor

The following links are for previewing this pull request:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcusTXK MarcusTXK MarcusTXK approved these changes

@ckcherry23 ckcherry23 ckcherry23 approved these changes

@sopa301 sopa301 sopa301 approved these changes

Assignees
No one assigned
Labels
s.ToMerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplication between the User Interface and class
4 participants
@jonasongg @MarcusTXK @ckcherry23 @sopa301