Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1769] Implement more Checkstyle checks #2022

Merged
merged 5 commits into from
Jul 28, 2023
Merged

[#1769] Implement more Checkstyle checks #2022

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8f733f2
Add stricter checkstyle
germainelee02 Jul 15, 2023
d0ef875
Fix PR comments
germainelee02 Jul 16, 2023
78ed510
Add back deleted newline
germainelee02 Jul 20, 2023
bdb5aee
Remove whitespace
germainelee02 Jul 20, 2023
c478201
Merge branch 'master' into feature/add-checkstyle
chan-j-d Jul 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion config/checkstyle/checkstyle.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@

<!-- All Java AST specific tests live under TreeWalker module. -->
<module name="TreeWalker">

germainelee02 marked this conversation as resolved.
Show resolved Hide resolved
<!-- Required to allow exceptions in code style -->
<module name="SuppressionCommentFilter">
<property name="offCommentFormat" value="CHECKSTYLE.OFF\: ([\w\|]+)"/>
Expand Down Expand Up @@ -218,6 +217,9 @@
ORDER CHECKS
-->

<!-- Checks that the default is after all the cases in a switch statement. -->
<module name="DefaultComesLast"/>

<!-- Checks that the order of at-clauses follows the tagOrder default property value order.
@author, @version, @param, @return, @throws, @exception, @see, @since, @serial, @serialField, @serialData, @deprecated
-->
Expand Down Expand Up @@ -245,6 +247,9 @@
WHITESPACE CHECKS
-->

<!-- Checks that there is no whitespace before the colon in a switch block. -->
<module name="NoWhitespaceBeforeCaseDefaultColon"/>

<!-- Checks that comments are indented relative to their position in the code -->
<module name="CommentsIndentation"/>

Expand Down Expand Up @@ -358,6 +363,12 @@
<!-- Checks that all Javadoc comments start from the second line. -->
<module name="JavadocContentLocationCheck" />

<!-- Checks the indentation of the continuation lines in block tags. -->
<module name="JavadocTagContinuationIndentation">
<property name="offset" value="0"/>
<property name="violateExecutionOnNonTightHtml" value="true"/>
</module>

<!-- Checks the Javadoc's format for every method (excluding getters, setters and constructors). -->
<module name="JavadocMethod">
<property name="allowMissingParamTags" value="true"/>
Expand Down
Loading