Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1769] Implement more Checkstyle checks #2022

Merged
merged 5 commits into from
Jul 28, 2023
Merged

[#1769] Implement more Checkstyle checks #2022

merged 5 commits into from
Jul 28, 2023

Conversation

germainelee02
Copy link
Contributor

@germainelee02 germainelee02 commented Jul 15, 2023 •
edited by chan-j-d
Loading

Fixes #1769

Currently, RepoSense does not have Checkstyle for 
- JavadocTagContinuationIndentation
- DefaultComesLast
- NoWhitespaceBeforeCaseDefaultColon.

Adding these checks can make it easier for future contributors 
to adhere to Reposense's coding style.

Let's add more Checkstyle checks to ensure easier standardisation
of code style.

yhtMinceraft1010X
yhtMinceraft1010X requested changes Jul 16, 2023
View reviewed changes
Copy link
Contributor

@yhtMinceraft1010X yhtMinceraft1010X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on identifying new checks.

For easier referencing by future developers, we group the checks into different sections below.

config/checkstyle/checkstyle.xml Outdated Show resolved Hide resolved
config/checkstyle/checkstyle.xml Outdated Show resolved Hide resolved
config/checkstyle/checkstyle.xml Outdated Show resolved Hide resolved
config/checkstyle/checkstyle.xml Outdated Show resolved Hide resolved
config/checkstyle/checkstyle.xml Outdated Show resolved Hide resolved
yhtMinceraft1010X
yhtMinceraft1010X approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@yhtMinceraft1010X yhtMinceraft1010X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yhtMinceraft1010X yhtMinceraft1010X requested review from a team July 20, 2023 15:09
ckcherry23
ckcherry23 approved these changes Jul 22, 2023
View reviewed changes
Copy link
Member

@ckcherry23 ckcherry23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chan-j-d
Copy link
Contributor

@germainelee02 Apologies as this is a little late but do note place the commit message in a code block as ckcherry has done for you. The links to the relevant documentation can be placed after the commit message together with any other relevant information for the PR.

@chan-j-d chan-j-d merged commit 1d20634 into reposense:master Jul 28, 2023
9 of 10 checks passed
@github-actions
Copy link
Contributor

The following links are for previewing this pull request:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckcherry23 ckcherry23 ckcherry23 approved these changes

@yhtMinceraft1010X yhtMinceraft1010X yhtMinceraft1010X approved these changes

Assignees
No one assigned
Labels
s.ToMerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement more Checkstyle checks
4 participants
@germainelee02 @chan-j-d @ckcherry23 @yhtMinceraft1010X