Hotfix: Revert all UNSAFE_ lifecycle methods

[danielrob]

The addition of the UNSAFE_ lifecycle methods broke React 15 compatibility. Those methods are not intended for libraries still supporting React 15.

The only way to remove the React 16.4+ StrictMode warnings about cWM, cWRP, and cWU in a React 15 compatible way is to migrate these methods to the new lifecycle methods and use react-lifecycles-compat for backwards compatibility. The UNSAFE_ methods were to support application authors with a known target version of React (16.3+) from having to migrate every component before upgrading. Unfortunately we can't do that trick.

Additional Testing

Since the automated tests are all run against React 16, I've confirmed this locally by building my fork, and copying the lib folder to node_modules/redux-form of a download of this sandbox which is against 15.6, and confirming that the initialValues (as per #4069) are now showing. That's the only test I've run.

Should fix

#4069, #4070, #4072

[erikras]

This is because I'm an idiot and didn't use the polyfill properly. I made the same mistake in another library.

[erikras]

I'll fix this immediately.

[codecov]

Codecov Report

Merging #4078 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #4078   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          72      72           
  Lines        1666    1661    -5     
======================================
- Hits         1666    1661    -5

Impacted Files	Coverage Δ
src/createReduxForm.js	100% <ø> (ø)	⬆️
src/createFields.js	100% <ø> (ø)	⬆️
src/Form.js	100% <ø> (ø)	⬆️
src/createField.js	100% <ø> (ø)	⬆️
src/createFieldArray.js	100% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 647a21f...a65f26c. Read the comment docs.

[erikras]

Published fix in v4.7.1.

[danielrob]

Sorry, I should have looked more deeply into the polyfill, they didn't mention on the front page it also supported the UNSAFE_ methods... I should have dug deeper! Thanks Erik!

[danielrob]

Wait... it doesn't...

[erikras]

Misunderstanding on my part, apparently. 🤦‍♂️

[erikras]

Published in v7.4.2.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.