Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use react-lifecycles-compat polyfill #4079

Merged
merged 1 commit into from
Jun 15, 2018
Merged

Conversation

erikras
Copy link
Member

@erikras erikras commented Jun 15, 2018

Deepest apologies for the reckless release of v7.4.0 without the React 16.3 polyfill.

Closes #4078
Fixes #4069
Fixes #4070
Fixes #4072

@erikras erikras merged commit 07d07a0 into master Jun 15, 2018
@erikras erikras deleted the react-lifecycle-compat branch June 15, 2018 09:42
@erikras
Copy link
Member Author

erikras commented Jun 15, 2018

Published in v7.4.1.

@erikras
Copy link
Member Author

erikras commented Jun 15, 2018

Nope.

@danielrob
Copy link
Collaborator

danielrob commented Jun 15, 2018

@erikras wait, but react-lifecycles-compat doesn't support the UNSAFE_ methods as far as I can tell... I think my PR is the only correct thing to do. See https://codesandbox.io/s/r0o9q33lmp

@lock
Copy link

lock bot commented Jul 15, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants