-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Radio buttons #177
Open
tim-habitat
wants to merge
13
commits into
pydantic:main
Choose a base branch
from
tim-habitat:radio-buttons
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Radio buttons #177
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
9f83c86
init add formfieldradio
tim-habitat 32a3a92
some fixes
tim-habitat e060a43
add to bootstrap package
tim-habitat 50ca37e
add test for radio
tim-habitat 9929abe
add tests for select choices forms
tim-habitat 1bf9580
fix tests
tim-habitat f63fe00
type needs to be 3.8 compat
tim-habitat b66f657
make option logic computation only once
tim-habitat a6875b1
raise if multiple and radio
tim-habitat 52dc459
remove duplication in react component
tim-habitat 391e414
add bootstrap classes for radio buttons
tim-habitat aee5458
lint js
tim-habitat bce110e
fix demo by having radio below multiple
tim-habitat File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,6 +10,7 @@ | |
FormFieldBoolean, | ||
FormFieldFile, | ||
FormFieldInput, | ||
FormFieldRadio, | ||
FormFieldSelect, | ||
FormFieldSelectSearch, | ||
FormFieldTextarea, | ||
|
@@ -259,16 +260,29 @@ | |
) | ||
elif enum := schema.get('enum'): | ||
enum_labels = schema.get('enum_labels', {}) | ||
return FormFieldSelect( | ||
name=name, | ||
title=title, | ||
placeholder=schema.get('placeholder'), | ||
required=required, | ||
multiple=multiple, | ||
options=[SelectOption(value=v, label=enum_labels.get(v) or as_title(v)) for v in enum], | ||
initial=schema.get('default'), | ||
description=schema.get('description'), | ||
) | ||
options = [SelectOption(value=v, label=enum_labels.get(v) or as_title(v)) for v in enum] | ||
if schema.get('mode') == 'radio' and multiple: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. addding this currently breaks the demo - as it appears that the |
||
raise ValueError('Radio buttons are not supported for multiple choice fields') | ||
elif schema.get('mode') == 'radio' and not multiple: | ||
return FormFieldRadio( | ||
name=name, | ||
title=title, | ||
required=required, | ||
options=options, | ||
initial=schema.get('default'), | ||
description=schema.get('description'), | ||
) | ||
else: | ||
return FormFieldSelect( | ||
name=name, | ||
title=title, | ||
placeholder=schema.get('placeholder'), | ||
required=required, | ||
multiple=multiple, | ||
options=options, | ||
initial=schema.get('default'), | ||
description=schema.get('description'), | ||
) | ||
elif search_url := schema.get('search_url'): | ||
return FormFieldSelectSearch( | ||
search_url=search_url, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking at your screenshot vs the bootstrap docs for Radios it appears you're missing some styling.
I think you need ot add some more classes here for radios, perhaps
form-check
,form-check-input
andform-check-label
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added both
![image](https://private-user-images.githubusercontent.com/86600518/304166358-baa765fd-e7a4-4abe-8bb5-a58d929cbb30.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkxMDQyMjYsIm5iZiI6MTcxOTEwMzkyNiwicGF0aCI6Ii84NjYwMDUxOC8zMDQxNjYzNTgtYmFhNzY1ZmQtZTdhNC00YWJlLThiYjUtYTU4ZDkyOWNiYjMwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjIzVDAwNTIwNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWE1ZDQ2M2NmMGE2YWQ1ZTIzOGQ2NmE3NjQxMGQ2YzE0YThmNjU3OThmMDdkMzNlZmVkZGNkMGJmNTkwNzE2NTgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.h0gFoUw2YLuNK962aQqEZb4K0pi4Aymy5_91iWIFEyc)
form-check-input
andform-check-label
- but i am unsure where i should add the classform-check
, i tried a few different places but it never seemed to work as intended.as it stands, here is how it looks: