Radio buttons #177
Radio buttons #177
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #177 +/- ##
==========================================
+ Coverage 94.30% 96.32% +2.01%
==========================================
Files 11 14 +3
Lines 755 952 +197
==========================================
+ Hits 712 917 +205
+ Misses 43 35 -8 ☔ View full report in Codecov by Sentry. |
| @@ -75,6 +75,7 @@ export const classNameGenerator: ClassNameGenerator = ({ | |||
| case 'FormFieldBoolean': | |||
| case 'FormFieldSelect': | |||
| case 'FormFieldSelectSearch': | |||
| case 'FormFieldRadio': | |||
There was a problem hiding this comment.
looking at your screenshot vs the bootstrap docs for Radios it appears you're missing some styling.
I think you need ot add some more classes here for radios, perhaps form-check, form-check-input and form-check-label?
There was a problem hiding this comment.
I added both form-check-input and form-check-label - but i am unsure where i should add the class form-check, i tried a few different places but it never seemed to work as intended.
as it stands, here is how it looks:
|
Overall, this is looking pretty good, thank you. |
| description=schema.get('description'), | ||
| ) | ||
| options = [SelectOption(value=v, label=enum_labels.get(v) or as_title(v)) for v in enum] | ||
| if schema.get('mode') == 'radio' and multiple: |
There was a problem hiding this comment.
addding this currently breaks the demo - as it appears that the json_schema param leak as well to the next component (which is a multiple)
i think similar to #178
Hi thanks again for the amazing project,
here's a trial of contribution - to be caveated i am very new to react / JS so there might very well be better ways to do this
but hope it helps.
trying to implement radio as described in issue: #160
Currrently it looks like this: