improve open pr matching for package updates #4025
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your site preview for commit 3833c41 is ready! 🎉 http://registry--origin-pr-4025-3833c41d.s3-website.us-west-2.amazonaws.com/registry. |
sean1588
changed the title
|
Related to #3739 |
cnunciato
approved these changes
Feb 26, 2024
| @@ -38,15 +38,15 @@ jobs: | |||
| id: regex-prov | |||
| run: | | |||
| if [[ "$REPO_SLUG" =~ (\/[^-]*-)(.*?$) ]]; then | |||
| echo "group2=${BASH_REMATCH[2]}" >> $GITHUB_OUTPUT | |||
| echo "group2= ${BASH_REMATCH[2]}" >> $GITHUB_OUTPUT | |||
There was a problem hiding this comment.
I'd probably add a comment indicating the spaces are significant (assuming I'm reading it right).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have issues where package names collide with titles of open PRs. This causes the update to the package to be skipped in these circumstances. An example of this that has occurred recently concerns the port provider. The word
portis found in an open PR with the wordSupportin the title. Since port is a substring of support, our job thinks there is already a PR open to update the provider. This PR does a quick fix to improve this a bit by checking that there is a leading whitespace before the provider name. I tested this to the best of my ability by running the workflow against my branch and with the added whitespace, theCheck if there is already an open PRstage of the job the which sets a variable to skip for this package,skip=1, is now longer being set, since I have added the whitespace (i.e. the variable is not set therefore telling the job not to skip the package)