feat(internet-exposed): New public exposed checks #3801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
provider/aws
jfagoagas
commented
Apr 17, 2024
Comment on lines
62
to
66
| if ( | ||
| lb.scheme == "internet-facing" | ||
| and lb.type == "application" | ||
| and len(lb.security_groups) > 0 | ||
| ): |
There was a problem hiding this comment.
I'd store all with a check of public if this condition is met.
jfagoagas
commented
Apr 17, 2024
Comment on lines
+16
to
+21
| "Remediation": { | ||
| "Code": { | ||
| "CLI": "", | ||
| "NativeIaC": "", | ||
| "Other": "", | ||
| "Terraform": "" |
jfagoagas
commented
Apr 17, 2024
Comment on lines
+16
to
+21
| "Remediation": { | ||
| "Code": { | ||
| "CLI": "", | ||
| "NativeIaC": "", | ||
| "Other": "", | ||
| "Terraform": "" |
jfagoagas
commented
Apr 17, 2024
Comment on lines
14
to
20
| "Remediation": { | ||
| "Code": { | ||
| "CLI": "https://www.trendmicro.com/cloudoneconformity/knowledge-base/aws/Lambda/function-exposed.html", | ||
| "NativeIaC": "https://www.trendmicro.com/cloudoneconformity/knowledge-base/aws/Lambda/function-exposed.html", | ||
| "Other": "", | ||
| "Terraform": "https://www.trendmicro.com/cloudoneconformity/knowledge-base/aws/Lambda/function-exposed.html" | ||
| }, |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3801 +/- ##
==========================================
+ Coverage 85.61% 85.63% +0.01%
==========================================
Files 731 740 +9
Lines 22659 22919 +260
==========================================
+ Hits 19400 19626 +226
- Misses 3259 3293 +34 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Thanks to @abant07 for this work! 👏
Fixes #3237
Description
New checks:
To-Do:
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.