Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws): Add new AWS Lambda check to check public access via other services #3642

Closed
wants to merge 2 commits into from

Conversation

abant07
Copy link

@abant07 abant07 commented Apr 2, 2024

Lambda test case not working @jfagoagas

@abant07 abant07 requested a review from a team as a code owner April 2, 2024 18:30
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Apr 2, 2024
@jfagoagas jfagoagas added the no-merge Please, DO NOT MERGE this PR. label Apr 4, 2024
@sergargar sergargar added the backport-v3 Pending to port to Prowler v3 branch label Apr 4, 2024
@jfagoagas jfagoagas changed the base branch from master-v3 to v3 April 8, 2024 06:35
@jfagoagas
Copy link
Member

Hi @abant07, we're about to review this PR but I don't get the point of the title and the PR body, can you elaborate it a little bit? Are you trying to fix an issue or just creating two new checks?

@abant07
Copy link
Author

abant07 commented Apr 15, 2024

Hey @jfagoagas

Sure, so for this PR I was adding a new feature to prowler where it would detect resources behind an internet facing ALB and ELB. I have written the two new checks for EC2 and it was working fine, however, I wrote a check for lambda and it was giving some trouble.

the check for lambda is giving a client token id error when I test it using mock_aws.

Thanks

@jfagoagas
Copy link
Member

Hey @jfagoagas

Sure, so for this PR I was adding a new feature to prowler where it would detect resources behind an internet facing ALB and ELB. I have written the two new checks for EC2 and it was working fine, however, I wrote a check for lambda and it was giving some trouble.

the check for lambda is giving a client token id error when I test it using mock_aws.

Thanks

So both are present in this PR right?

  1. Review these new checks
  2. Fix the issue with the new Lambda check called awslambda_function_not_directly_publicly_accessible_via_elbv.

Am I right?

Thanks!

@abant07
Copy link
Author

abant07 commented Apr 15, 2024

Yup you got it.

Thanks

@jfagoagas jfagoagas changed the title AWS Lambda check for #3237 is not passing test cases due to client token id error feat(aws): Add new AWS Lambda check to check public access via other services Apr 16, 2024
@jfagoagas
Copy link
Member

@abant07 we need push permissions to your branch in order to fix and improve some parts of the code.

@abant07
Copy link
Author

abant07 commented Apr 16, 2024

Sure, I have just invited you.

Thanks

@jfagoagas
Copy link
Member

Closed in favor of #3801

@jfagoagas jfagoagas closed this Apr 17, 2024
@jfagoagas jfagoagas removed the backport-v3 Pending to port to Prowler v3 branch label Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-merge Please, DO NOT MERGE this PR. provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants