Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] autocomplete empty input request #777

Open
wants to merge 2 commits into
base: bundlephobia
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 15 additions & 1 deletion __tests__/utils.test.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
import { parsePackageString } from '../utils/common.utils'
const { parsePackageString, isEmpty } = require('../utils/common.utils')

describe('parsePackageString', () => {
it('handles scoped packages correctly', () => {
expect(parsePackageString('@babel/[email protected]')).toEqual({
scoped: true,
name: '@babel/core',
scope: 'babel',
version: '9.8.0',
})
})
Expand All @@ -13,6 +14,7 @@ describe('parsePackageString', () => {
expect(parsePackageString('@babel/core')).toEqual({
scoped: true,
name: '@babel/core',
scope: 'babel',
version: null,
})
})
Expand Down Expand Up @@ -49,3 +51,15 @@ describe('parsePackageString', () => {
})
})
})

describe('isEmpty', () => {
it('should return true for empty string', () => {
expect(isEmpty('')).toBe(true)
expect(isEmpty(' ')).toBe(true)
})

it('should return false for non-empty string', () => {
expect(isEmpty('Hello')).toBe(false)
expect(isEmpty(' Hello ')).toBe(false)
})
})
28 changes: 28 additions & 0 deletions client/components/AutocompleteInput/AutocompleteInput.scss
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,34 @@
width: 100%;
}

.autocomplete-input__container--error {
animation-duration: 0.75s;
animation-fill-mode: both;
animation-name: shakeX;
}

@keyframes shakeX {
from,
to {
transform: translate3d(0, 0, 0);
}

10%,
30%,
50%,
70%,
90% {
transform: translate3d(-6px, 0, 0);
}

20%,
40%,
60%,
80% {
transform: translate3d(6px, 0, 0);
}
}

.autocomplete-input {
width: 40vw;
border: none;
Expand Down
4 changes: 4 additions & 0 deletions client/components/AutocompleteInput/AutocompleteInput.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ export const AutocompleteInput = ({
handleInputChange,
setIsMenuVisible,
setSuggestions,
isValidationError,
errorClearHandler,
} = useAutocompleteInput({ initialValue, onSubmit: onSearchSubmit })
const { searchFontSize } = useFontSize({ value })

Expand All @@ -51,7 +53,9 @@ export const AutocompleteInput = ({
className={cx('autocomplete-input__container', className, {
'autocomplete-input__container--menu-visible':
isMenuVisible && !!suggestions.length,
'autocomplete-input__container--error': isValidationError,
})}
onAnimationEnd={errorClearHandler}
>
<AutoComplete
getItemValue={item => item.package.name}
Expand Down
15 changes: 13 additions & 2 deletions client/components/AutocompleteInput/hooks/useAutocompleteInput.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React from 'react'
import debounce from 'debounce'

import { parsePackageString } from '../../../../utils/common.utils'
import { parsePackageString, isEmpty } from '../../../../utils/common.utils'
import API from '../../../api'

interface UseAutocompleteInputArgs {
Expand All @@ -16,6 +16,7 @@ export function useAutocompleteInput({
const [value, setValue] = React.useState(initialValue)
const [suggestions, setSuggestions] = React.useState<any[]>([])
const [isMenuVisible, setIsMenuVisible] = React.useState(false)
const [isValidationError, setIsValidationError] = React.useState(false)

const getSuggestions = React.useMemo(
() =>
Expand All @@ -27,9 +28,17 @@ export function useAutocompleteInput({
[]
)

const errorClearHandler = () => {
setIsValidationError(false)
}

const handleSubmit = (e: React.FormEvent) => {
e.preventDefault()
onSubmit(value)
if (!isEmpty(value)) {
onSubmit(value)
} else {
setIsValidationError(true)
}
}

const handleInputChange = (
Expand Down Expand Up @@ -57,5 +66,7 @@ export function useAutocompleteInput({
handleInputChange,
setIsMenuVisible,
setSuggestions,
isValidationError,
errorClearHandler,
}
}
11 changes: 10 additions & 1 deletion utils/common.utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,4 +50,13 @@ function sanitizeHTML(html) {
})
}

module.exports = { parsePackageString, daysFromToday, sanitizeHTML }
/**
* replace it when refactor to TS
* @param {string} str - input string
* @returns boolean
* */
function isEmpty(str) {
return !str.trim().length
}

module.exports = { parsePackageString, daysFromToday, sanitizeHTML, isEmpty }