Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] autocomplete empty input request #777

Open
wants to merge 2 commits into
base: bundlephobia
Choose a base branch
from

Conversation

upteran
Copy link

@upteran upteran commented Apr 19, 2023

Description

  • add check before request send
  • add little animation on input error (thought it not form with huge list of inputs, can use some animation)
  • add tests and fix parser old test (some of them were fail)

Related Issue

Closes #770

Context

I've seen few options to fix this:

  • add check to handler in component (with/without animation)
  • add required attr to autocomplete input (mean this one), it's easier and native, but in diff browser we'll get different design of tooltips. And I thought in this case we can use more complex solution and get animation and controlled view

Check pls and if animation is not need, I can replace it with required attr or another way you prefer )

Screenshots:

example-shake

@pastelsky
Copy link
Owner

Love the little shake! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting 404 for empty input
2 participants