UI: Add (eRTMP) multitrack video output #10633
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palana
force-pushed
the
ruwen/upstream-multitrack-video-ui
branch
2 times, most recently
from
9a86687
to
f910c0f
Compare
tytan652
suggested changes
May 3, 2024
There was a problem hiding this comment.
This feature is clearly not implemented in a future-proof way, it tangles even more service behavior in the UI that should be plugin-ified (with APIs).
Continuously shoehorning service integrations was already a mistake, and this PR goes to the same wrong direction rather than trying to go to a better direction.
6 tasks
palana
force-pushed
the
ruwen/upstream-multitrack-video-ui
branch
2 times, most recently
from
7b7c4e7
to
76bde8f
Compare
palana
force-pushed
the
ruwen/upstream-multitrack-video-ui
branch
7 times, most recently
from
a853a6b
to
b4f7a5e
Compare
palana
force-pushed
the
ruwen/upstream-multitrack-video-ui
branch
from
be16cb1
to
25ffb6c
Compare
6 tasks
RytoEX
force-pushed
the
ruwen/upstream-multitrack-video-ui
branch
from
439afe6
to
48cb2a9
Compare
Disables all children of the properties view.
Switch `post_data` to use nlohmann json
Switch go live config to use nlohmann json
Dumping config json from nlohmann requires more than 4096 bytes
Remove preparing event
Bypass config download etc when service is set to custom and no auto config url is available
Fix getting correct strings
Use correct strings
Use correct strings
Reduce spacing for upper UI elements to make room
fixup! UI: Add output settings indicators for eRTMP multitrack video
|
Rebased first. Now pushing cleanups:
|
RytoEX
force-pushed
the
ruwen/upstream-multitrack-video-ui
branch
from
48cb2a9
to
932269d
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this PR includes a bunch of merges from currently open PRs and a FIXME commit to help with testing, which will go away as soon as the dependency PRs are merged
Description
This implements multitrack video support for Twitch Enhanced Broadcasting and Amazon IVS Multitrack Video
Motivation and Context
Multitrack video/Enhanced Broadcasting allows sending multiple video tracks/renditions from the users machine, resulting in generally higher quality renditions at lower bitrates compared to single track streaming with server side transcoding, since e.g. losses roundtripping frames through another decode/encode step are removed.
Enhanced Broadcasting/multitrack video uses server side configuration to provide easier onboarding for users, and balanced values for the number of renditions and their bitrates.
How Has This Been Tested?
This has been tested in the Twitch Enhanced Broadcasting beta
Types of changes
Checklist: