UI: Add support for additional canvases to multitrack video output #10635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtmp-services: Add Multitrack Video disclaimer
rtmp-services: Populate Twitch specific multitrack video settings
This will be initialized to 0 in various cases, so let's make that a valid enum value (even if it's not valid in rtmp?)
…ltitrack-video-ui
…eam-multitrack-video-ui
The status bar doesn't currently own its references to outputs, which can be a problem if e.g. streaming outputs are released soon after stream stop. The Multitrack Video output does exactly that, so the status bar will sometimes try to access an invalid pointer for updating its stats. Keeping a weak reference around and upgrading it to collect stats, similar to how the stats window behaves.
palana
force-pushed
the
ruwen/vertical-canvas-integration
branch
from
4e30c28
to
5737ed6
Compare
Disables all children of the properties view.
Co-authored-by: Ruwen Hahn <[email protected]>
palana
force-pushed
the
ruwen/vertical-canvas-integration
branch
from
ce1b263
to
c03b4fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #10633
Description
Adds frontend API calls to allow plugins to register additional canvases/video outputs that will participate in multitrack video configuration generation and multitrack video streams
Motivation and Context
Currently additional views/canvases have to use separate rtmp connections or similar to be streamed, where the multitrack video output allows both multiple renditions of the same view and also different views to be streamed
How Has This Been Tested?
Twitch Enhanced Broadcasting beta
Types of changes
Checklist: