Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Updated inject example to show constructor usage #162

Merged
merged 1 commit into from
Jun 14, 2023
Merged

docs: Updated inject example to show constructor usage #162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/docs/lumberjack-docs-app/docs/usage.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ import { LumberjackService } from '@ngworker/lumberjack';
// (...)
})
export class MyComponent implements OnInit {
readonly #lumberjack = inject(LumberjackService);
constructor(private readonly lumberjack: LumberjackService) {}
Copy link
Contributor Author

@ajitzero ajitzero Jun 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reviewers: Expand below and see Line 110 for comparison.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: nice catch!


// (...)
}
Expand Down