docs: Updated inject example to show constructor usage #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportAttention: This version of the Nx Cloud GitHub bot will cease to function on July 1st, 2023. An organization admin can update your integration here. CI is running/has finished running commands for commit 2077fa5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
ajitzero
commented
Jun 14, 2023
| @@ -91,7 +91,7 @@ import { LumberjackService } from '@ngworker/lumberjack'; | |||
| // (...) | |||
| }) | |||
| export class MyComponent implements OnInit { | |||
| readonly #lumberjack = inject(LumberjackService); | |||
| constructor(private readonly lumberjack: LumberjackService) {} | |||
There was a problem hiding this comment.
For reviewers: Expand below and see Line 110 for comparison.
|
Thanks for the PR @ajitzero ! Very appreciated. I'll take a look right now. |
NachoVazquez
approved these changes
Jun 14, 2023
| @@ -91,7 +91,7 @@ import { LumberjackService } from '@ngworker/lumberjack'; | |||
| // (...) | |||
| }) | |||
| export class MyComponent implements OnInit { | |||
| readonly #lumberjack = inject(LumberjackService); | |||
| constructor(private readonly lumberjack: LumberjackService) {} | |||
|
@all-contributors please add @ajitzero for docs |
|
I've put up a pull request to add @ajitzero! 🎉 |
NachoVazquez
added a commit
that referenced
this pull request
Jun 14, 2023
Adds @ajitzero as a contributor for doc. This was requested by NachoVazquez [in this comment](#162 (comment)) [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Nacho Vazquez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Duplicate example in https://ngworker.github.io/lumberjack/docs/usage#using-the-lumberjackservice where both show usage with
inject().Issue Number: N/A
What is the new behavior?
Updated the first example to use the constructor for injection.
Does this PR introduce a breaking change?
Other information
Fixes #163