Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPI] logsumexp #1495

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

[MPI] logsumexp #1495

wants to merge 7 commits into from

Commits on Jun 9, 2023

  1. mpi-aware logsumexp

    inailuig committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    45f9749 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2023

  1. add an error if mpi_max is called with complex input

    Also fix the docstring.
    
    Previously one got the following errors:
    
    mpi4jax:
    ```
    MPI_ABORT was invoked on rank 0 in communicator MPI COMMUNICATOR 4 
    CREATE FROM 0 with errorcode 10.
    ```
    mpi4py:
    ``
    mpi4py.MPI.Exception: MPI_ERR_OP: invalid reduce operation
    ```
    reproducer:
    
    ```python
    import netket as nk
    import jax.numpy as jnp
    x = 1.j
    y = jnp.ones(2, dtype=complex)
    #nk.utils.mpi.mpi_max(x)
    #nk.utils.mpi.mpi_max_jax(x)
    nk.utils.mpi.mpi_max_jax(y)
    ```
    inailuig committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    677d104 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b5bade9 View commit details
    Browse the repository at this point in the history
  3. test with complex array

    inailuig committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    f31f6f9 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2023

  1. docstr typo

    inailuig committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    ce17e9b View commit details
    Browse the repository at this point in the history
  2. also test scalar arr

    inailuig committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    e96e00e View commit details
    Browse the repository at this point in the history
  3. fix for scalar arr

    inailuig committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    d55d1a1 View commit details
    Browse the repository at this point in the history