[MPI] logsumexp #1495
Draft
[MPI] logsumexp #1495
+234
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1495 +/- ##
==========================================
- Coverage 83.78% 82.86% -0.92%
==========================================
Files 240 241 +1
Lines 13687 13742 +55
Branches 2076 2095 +19
==========================================
- Hits 11467 11387 -80
- Misses 1706 1823 +117
- Partials 514 532 +18
|
Also fix the docstring. Previously one got the following errors: mpi4jax: ``` MPI_ABORT was invoked on rank 0 in communicator MPI COMMUNICATOR 4 CREATE FROM 0 with errorcode 10. ``` mpi4py: `` mpi4py.MPI.Exception: MPI_ERR_OP: invalid reduce operation ``` reproducer: ```python import netket as nk import jax.numpy as jnp x = 1.j y = jnp.ones(2, dtype=complex) #nk.utils.mpi.mpi_max(x) #nk.utils.mpi.mpi_max_jax(x) nk.utils.mpi.mpi_max_jax(y) ```
PhilipVinc
force-pushed
the
master
branch
3 times, most recently
from
562101f
to
5d8bad1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an mpi-aware logsumexp.
Will be useful for e.g. computing the statistics of importance sampling.