Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-#5196: Support pandas tseries and offsets. #5197

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

FIX-#5196: Support pandas tseries and offsets. #5197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a732675
FIX-#5196: Support pandas tseries and offsets.
Nov 4, 2022
da2f99c
Remove np check.
Nov 9, 2022
ce51a36
Add back np for py36.
Nov 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions modin/pandas/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,8 @@
NamedAgg,
NA,
api,
tseries,
offsets,
Comment on lines +99 to +100
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't these modules return objects that Modin should wrap in Series or DataFrame?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not offsets. some other stuff in tseries yes

)
import os

Expand Down Expand Up @@ -365,6 +367,8 @@ def init_remote_ray(partition):
"NamedAgg",
"api",
"read_xml",
"tseries",
"offsets",
]

if PandasCompatVersion.CURRENT != PandasCompatVersion.PY36:
Expand Down
2 changes: 0 additions & 2 deletions modin/pandas/test/test_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,9 @@ def test_top_level_api_equality():
"core",
"compat",
"util",
"offsets",
"datetime",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datetime and np are not in the namespace in main anymore

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

datetime isn't in dir(pandas), but I can do from pandas import datetime. Not sure how that works. I removed np.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but I can do from pandas import datetime

sure you're using main?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried main-- I get ImportError: cannot import name 'get_supported_reso' from 'pandas._libs.tslibs.dtypes'. But Modin CI isn't using main pandas, so we can't change this yet.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you likely need to re-build

"arrays",
"api",
"tseries",
anmyachev marked this conversation as resolved.
Show resolved Hide resolved
"errors",
"to_msgpack", # This one is experimental, and doesn't look finished
"describe_option",
Expand Down