FIX-#5196: Support pandas tseries and offsets. #5197
Conversation
| @@ -33,11 +33,9 @@ def test_top_level_api_equality(): | |||
| "core", | |||
| "compat", | |||
| "util", | |||
| "offsets", | |||
| "datetime", | |||
There was a problem hiding this comment.
Datetime and np are not in the namespace in main anymore
There was a problem hiding this comment.
datetime isn't in dir(pandas), but I can do from pandas import datetime. Not sure how that works. I removed np.
There was a problem hiding this comment.
but I can do from pandas import datetime
sure you're using main?
There was a problem hiding this comment.
I just tried main-- I get ImportError: cannot import name 'get_supported_reso' from 'pandas._libs.tslibs.dtypes'. But Modin CI isn't using main pandas, so we can't change this yet.
There was a problem hiding this comment.
you likely need to re-build
Signed-off-by: mvashishtha <[email protected]>
Signed-off-by: mvashishtha <[email protected]>
Signed-off-by: mvashishtha <[email protected]>
mvashishtha
force-pushed
the
5196-support-tseries-offsets
branch
from
a1a7610
to
ce51a36
Compare
| tseries, | ||
| offsets, |
There was a problem hiding this comment.
Don't these modules return objects that Modin should wrap in Series or DataFrame?
There was a problem hiding this comment.
not offsets. some other stuff in tseries yes
Signed-off-by: mvashishtha [email protected]
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sdocs/development/architecture.rstis up-to-date