Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calling store.UpdateFeed and store.UpdateFeedError in a defer function #2222

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

shizunge
Copy link
Contributor

@shizunge shizunge commented Nov 29, 2023

To calculate and to commit next check at in a single place.

Want to do this cleanup before working on #412

Do you follow the guidelines?

@shizunge
Copy link
Contributor Author

@shizunge shizunge marked this pull request as draft November 29, 2023 04:44
@shizunge shizunge force-pushed the defer-calling-schedule branch 2 times, most recently from bfa53fe to 4e8b8e6 Compare December 1, 2023 05:28
@shizunge shizunge marked this pull request as ready for review December 1, 2023 23:18
@shizunge
Copy link
Contributor Author

shizunge commented Dec 4, 2023

rebased

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant