calling store.UpdateFeed and store.UpdateFeedError in a defer function

internal/reader/handler/handler.go

@@ -227,7 +227,30 @@ func RefreshFeed(store *storage.Storage, userID, feedID int64, forceRefresh bool
  }
 
  originalFeed.CheckedNow()
- originalFeed.ScheduleNextCheck(weeklyEntryCount, newTTL)
+ // Commit the result to the database at the end of this function.
+ // If we met an error before entering the defer function, localizedError would not be nil.
+ defer func() {
+ originalFeed.ScheduleNextCheck(weeklyEntryCount, newTTL)
+ slog.Debug("Updated next check date",
+ slog.Int64("user_id", userID),
+ slog.Int64("feed_id", feedID),
+ slog.Int("weeklyEntryCount", weeklyEntryCount),
+ slog.Int("ttl", newTTL),
+ slog.Time("new_next_check_at", originalFeed.NextCheckAt),
+ )
+ if localizedError == nil {
+ // We have not encountered any error before entering this delay function.
+ originalFeed.ResetErrorCounter()
+ if storeErr := store.UpdateFeed(originalFeed); storeErr != nil {
+ // Update the return value when there is an error.
+ localizedError = locale.NewLocalizedErrorWrapper(storeErr, "error.database_error", storeErr)
+ }
+ }
+ if localizedError != nil {
+ originalFeed.WithTranslatedErrorMessage(localizedError.Translate(user.Language))
+ store.UpdateFeedError(originalFeed)
+ }
+ }()
 
  requestBuilder := fetcher.NewRequestBuilder()
  requestBuilder.WithUsernameAndPassword(originalFeed.Username, originalFeed.Password)
@@ -245,15 +268,11 @@ func RefreshFeed(store *storage.Storage, userID, feedID int64, forceRefresh bool
 
  if localizedError = responseHandler.LocalizedError(); localizedError != nil {
  slog.Warn("Unable to fetch feed", slog.String("feed_url", originalFeed.FeedURL), slog.Any("error", localizedError.Error()))
- originalFeed.WithTranslatedErrorMessage(localizedError.Translate(user.Language))
- store.UpdateFeedError(originalFeed)
  return localizedError
  }
 
  if store.AnotherFeedURLExists(userID, originalFeed.ID, responseHandler.EffectiveURL()) {
  localizedError = locale.NewLocalizedErrorWrapper(ErrDuplicatedFeed, "error.duplicated_feed")
- originalFeed.WithTranslatedErrorMessage(localizedError.Translate(user.Language))
- store.UpdateFeedError(originalFeed)
  return localizedError
  }
 
@@ -271,27 +290,16 @@ func RefreshFeed(store *storage.Storage, userID, feedID int64, forceRefresh bool
 
  updatedFeed, parseErr := parser.ParseFeed(responseHandler.EffectiveURL(), bytes.NewReader(responseBody))
  if parseErr != nil {
- localizedError := locale.NewLocalizedErrorWrapper(parseErr, "error.unable_to_parse_feed", parseErr)
-
  if errors.Is(parseErr, parser.ErrFeedFormatNotDetected) {
  localizedError = locale.NewLocalizedErrorWrapper(parseErr, "error.feed_format_not_detected", parseErr)
+ } else {
+ localizedError = locale.NewLocalizedErrorWrapper(parseErr, "error.unable_to_parse_feed", parseErr)
  }
-
- originalFeed.WithTranslatedErrorMessage(localizedError.Translate(user.Language))
- store.UpdateFeedError(originalFeed)
  return localizedError
  }
 
  // If the feed has a TTL defined, we use it to make sure we don't check it too often.
  newTTL = updatedFeed.TTL
- // Set the next check at with updated arguments.
- originalFeed.ScheduleNextCheck(weeklyEntryCount, newTTL)
- slog.Debug("Updated next check date",
- slog.Int64("user_id", userID),
- slog.Int64("feed_id", feedID),
- slog.Int("ttl", newTTL),
- slog.Time("new_next_check_at", originalFeed.NextCheckAt),
- )
 
  originalFeed.Entries = updatedFeed.Entries
  processor.ProcessFeedEntries(store, originalFeed, user, forceRefresh)
@@ -301,8 +309,6 @@ func RefreshFeed(store *storage.Storage, userID, feedID int64, forceRefresh bool
  newEntries, storeErr := store.RefreshFeedEntries(originalFeed.UserID, originalFeed.ID, originalFeed.Entries, updateExistingEntries)
  if storeErr != nil {
  localizedError = locale.NewLocalizedErrorWrapper(storeErr, "error.database_error", storeErr)
- originalFeed.WithTranslatedErrorMessage(localizedError.Translate(user.Language))
- store.UpdateFeedError(originalFeed)
  return localizedError
  }
 
@@ -336,15 +342,6 @@ func RefreshFeed(store *storage.Storage, userID, feedID int64, forceRefresh bool
  )
  }
 
- originalFeed.ResetErrorCounter()
-
- if storeErr := store.UpdateFeed(originalFeed); storeErr != nil {
- localizedError = locale.NewLocalizedErrorWrapper(storeErr, "error.database_error", storeErr)
- originalFeed.WithTranslatedErrorMessage(localizedError.Translate(user.Language))
- store.UpdateFeedError(originalFeed)
- return localizedError
- }
-
  return localizedError
 }