enhance: Add param item to ignore bad message id in checkpoint #33123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See also milvus-io#33122 This pr add param item `mq.ignoreBadPosition` to control behavior when mq failed to parse message id from checkpoint Signed-off-by: Congqi Xia <[email protected]>
mergify
bot
added
dco-passed
|
@congqixia E2e jenkins job failed, comment |
Signed-off-by: Congqi Xia <[email protected]>
sre-ci-robot
added
size/L
|
@congqixia E2e jenkins job failed, comment |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #33123 +/- ##
==========================================
- Coverage 82.14% 82.13% -0.01%
==========================================
Files 1006 1006
Lines 128452 128461 +9
==========================================
- Hits 105513 105511 -2
- Misses 18948 18966 +18
+ Partials 3991 3984 -7
|
|
/run-cpu-e2e |
1 similar comment
|
/run-cpu-e2e |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, xiaofan-luan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sre-ci-robot
pushed a commit
that referenced
this pull request
May 20, 2024
…33128) Cherry-pick from master pr: #33123 See also #33122 This pr add param item `mq.ignoreBadPosition` to control behavior when mq failed to parse message id from checkpoint --------- Signed-off-by: Congqi Xia <[email protected]>
congqixia
added a commit
to congqixia/milvus
that referenced
this pull request
May 22, 2024
…s-io#33123) See also milvus-io#33122 This pr add param item `mq.ignoreBadPosition` to control behavior when mq failed to parse message id from checkpoint --------- Signed-off-by: Congqi Xia <[email protected]>
sre-ci-robot
pushed a commit
that referenced
this pull request
May 23, 2024
…33123) (#33249) Cherry-pick from master pr: #33123 #33158 See also #33122 This pr add param item `mq.ignoreBadPosition` to control behavior when mq failed to parse message id from checkpoint --------- Signed-off-by: Congqi Xia <[email protected]> --------- Signed-off-by: Congqi Xia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #33122
This pr add param item
mq.ignoreBadPositionto control behavior when mq failed to parse message id from checkpoint