-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: [2.3] Add param item to ignore bad message id in checkpoint #33128
Conversation
See also milvus-io#33122 This pr add param item `mq.ignoreBadPosition` to control behavior when mq failed to parse message id from checkpoint Signed-off-by: Congqi Xia <[email protected]>
@congqixia E2e jenkins job failed, comment |
/run-cpu-e2e |
@congqixia E2e jenkins job failed, comment |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.3 #33128 +/- ##
==========================================
+ Coverage 83.06% 83.09% +0.02%
==========================================
Files 850 850
Lines 106629 106641 +12
==========================================
+ Hits 88576 88613 +37
+ Misses 14742 14730 -12
+ Partials 3311 3298 -13
|
/run-cpu-e2e |
Signed-off-by: Congqi Xia <[email protected]>
@congqixia E2e jenkins job failed, comment |
/run-cpu-e2e |
@congqixia E2e jenkins job failed, comment |
/run-cpu-e2e |
@congqixia E2e jenkins job failed, comment |
1 similar comment
@congqixia E2e jenkins job failed, comment |
/run-cpu-e2e |
@congqixia E2e jenkins job failed, comment |
/run-cpu-e2e |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, xiaofan-luan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Cherry-pick from master
pr: #33123
See also #33122
This pr add param item
mq.ignoreBadPosition
to control behavior when mq failed to parse message id from checkpoint