Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Remove deprecated EnableIndex #32704

Merged
merged 1 commit into from May 7, 2024

Conversation

bigsheeper
Copy link
Contributor

/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Apr 29, 2024
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Apr 29, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Apr 29, 2024
@bigsheeper
Copy link
Contributor Author

rerun ut

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.75%. Comparing base (6289f3a) to head (2f19adf).
Report is 37 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32704      +/-   ##
==========================================
+ Coverage   81.72%   81.75%   +0.03%     
==========================================
  Files         998      998              
  Lines      124209   124208       -1     
==========================================
+ Hits       101513   101550      +37     
+ Misses      18822    18791      -31     
+ Partials     3874     3867       -7     
Files Coverage Δ
internal/querycoordv2/meta/coordinator_broker.go 92.12% <100.00%> (ø)
internal/querynodev2/segments/segment.go 68.33% <100.00%> (ø)
internal/querynodev2/segments/segment_loader.go 72.06% <100.00%> (-0.03%) ⬇️

... and 26 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Apr 29, 2024
@czs007
Copy link
Contributor

czs007 commented May 7, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 9db3aa1 into milvus-io:master May 7, 2024
15 checks passed
bigsheeper added a commit to bigsheeper/milvus that referenced this pull request May 7, 2024
sre-ci-robot pushed a commit that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants