enhance: Remove deprecated EnableIndex (milvus-io#32704)

/kind improvement Signed-off-by: bigsheeper <[email protected]>
bigsheeper · May 7, 2024 · 0bf6e95 · 0bf6e95
1 parent 49b760f
commit 0bf6e95
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 8 deletions.
diff --git a/internal/querycoordv2/meta/coordinator_broker.go b/internal/querycoordv2/meta/coordinator_broker.go
@@ -229,7 +229,7 @@ func (broker *CoordinatorBroker) GetIndexInfo(ctx context.Context, collectionID
  for _, info := range segmentInfo.GetIndexInfos() {
  indexes = append(indexes, &querypb.FieldIndexInfo{
  FieldID: info.GetFieldID(),
- EnableIndex: true,
+ EnableIndex: true, // deprecated, but keep it for compatibility
  IndexName: info.GetIndexName(),
  IndexID: info.GetIndexID(),
  BuildID: info.GetBuildID(),

diff --git a/internal/querynodev2/segments/mock_data.go b/internal/querynodev2/segments/mock_data.go
@@ -1075,7 +1075,6 @@ func GenAndSaveIndexV2(collectionID, partitionID, segmentID, buildID int64,
 
  return &querypb.FieldIndexInfo{
  FieldID: fieldSchema.GetFieldID(),
- EnableIndex: true,
  IndexName: indexInfo.GetIndexName(),
  IndexParams: indexInfo.GetIndexParams(),
  IndexFilePaths: indexPaths,
@@ -1136,7 +1135,6 @@ func GenAndSaveIndex(collectionID, partitionID, segmentID, fieldID int64, msgLen
 
  return &querypb.FieldIndexInfo{
  FieldID: fieldID,
- EnableIndex: true,
  IndexName: "querynode-test",
  IndexParams: funcutil.Map2KeyValuePair(indexParams),
  IndexFilePaths: indexPaths,

diff --git a/internal/querynodev2/segments/segment.go b/internal/querynodev2/segments/segment.go
@@ -440,7 +440,7 @@ func (s *LocalSegment) ExistIndex(fieldID int64) bool {
  if !ok {
  return false
  }
- return fieldInfo.IndexInfo != nil && fieldInfo.IndexInfo.EnableIndex
+ return fieldInfo.IndexInfo != nil
 }
 
 func (s *LocalSegment) HasRawData(fieldID int64) bool {

diff --git a/internal/querynodev2/segments/segment_loader.go b/internal/querynodev2/segments/segment_loader.go
@@ -1508,10 +1508,8 @@ func getResourceUsageEstimateOfSegment(schema *schemapb.CollectionSchema, loadIn
 
  vecFieldID2IndexInfo := make(map[int64]*querypb.FieldIndexInfo)
  for _, fieldIndexInfo := range loadInfo.IndexInfos {
- if fieldIndexInfo.EnableIndex {
- fieldID := fieldIndexInfo.FieldID
- vecFieldID2IndexInfo[fieldID] = fieldIndexInfo
- }
+ fieldID := fieldIndexInfo.FieldID
+ vecFieldID2IndexInfo[fieldID] = fieldIndexInfo
  }
 
  for _, fieldBinlog := range loadInfo.BinlogPaths {