Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: for supporting ARM-based GPU images #31757

Merged
merged 1 commit into from
Apr 3, 2024
Merged

enhance: for supporting ARM-based GPU images #31757

merged 1 commit into from
Apr 3, 2024

Conversation

samhuang-z
Copy link
Collaborator

@samhuang-z samhuang-z commented Mar 30, 2024 •
edited

This PR is for supporting ARM-based GPU images.
issue: #31862

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Mar 30, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Mar 30, 2024
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Mar 30, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 30, 2024

@samhuang-z Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@codecov Codecov
Copy link

codecov bot commented Mar 30, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.11%. Comparing base (417c678) to head (828824e).
Report is 31 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #31757      +/-   ##
==========================================
+ Coverage   81.05%   81.11%   +0.05%     
==========================================
  Files         979      979              
  Lines      140565   140690     +125     
==========================================
+ Hits       113940   114114     +174     
+ Misses      22809    22780      -29     
+ Partials     3816     3796      -20

see 72 files with indirect coverage changes

@mergify mergify bot removed the ci-passed label Mar 31, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 31, 2024

@samhuang-z E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify mergify bot added needs-dco DCO is missing in this pull request. and removed dco-passed DCO check passed. labels Mar 31, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 31, 2024

@samhuang-z Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added ci-passed and removed ci-passed labels Mar 31, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 31, 2024

@samhuang-z E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify mergify bot added the ci-passed label Mar 31, 2024
@mergify mergify bot added dco-passed DCO check passed. ci-passed and removed needs-dco DCO is missing in this pull request. ci-passed labels Apr 1, 2024
@samhuang-z samhuang-z changed the title enhance: dockerfile for gpu enhance: dockerfile for miluvs arm gpu Apr 1, 2024
@mergify mergify bot removed the ci-passed label Apr 1, 2024
@samhuang-z samhuang-z changed the title enhance: dockerfile for miluvs arm gpu enhance: pipeline and dockerfile for miluvs arm gpu Apr 1, 2024
@samhuang-z samhuang-z changed the title enhance: pipeline and dockerfile for miluvs arm gpu enhance: for supporting ARM-based GPU images Apr 1, 2024
@mergify mergify bot added the ci-passed label Apr 1, 2024
@mergify mergify bot added ci-passed and removed ci-passed labels Apr 2, 2024
@samhuang-z
enhance: for arm-based gpu image
828824e 
Signed-off-by: Liang Huang <[email protected]>

.

Signed-off-by: Liang Huang <[email protected]>
@mergify mergify bot added ci-passed and removed ci-passed labels Apr 2, 2024
@samhuang-z samhuang-z mentioned this pull request Apr 2, 2024
Merged
@mergify mergify bot removed the ci-passed label Apr 3, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 3, 2024

@samhuang-z E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

LoveEachDay
LoveEachDay approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@LoveEachDay LoveEachDay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 3, 2024

@samhuang-z E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yanliang567
Copy link
Contributor

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LoveEachDay, samhuang-z, yanliang567

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot pushed a commit that referenced this pull request Apr 3, 2024
@samhuang-z
enhance: for arm-based gpu image (#31830)
3c14c8a 
pr: #31757

Signed-off-by: Liang Huang <[email protected]>
@mergify mergify bot added the ci-passed label Apr 3, 2024
@sre-ci-robot sre-ci-robot merged commit b11c2da into milvus-io:master Apr 3, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoveEachDay LoveEachDay LoveEachDay approved these changes

@czs007 czs007 Awaiting requested review from czs007

Assignees

@LoveEachDay LoveEachDay

Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@samhuang-z @yanliang567 @sre-ci-robot @LoveEachDay