Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: for arm-based gpu image #31830

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Conversation

samhuang-z
Copy link
Collaborator

@samhuang-z samhuang-z commented Apr 2, 2024

pr: #31757

Signed-off-by: Liang Huang <[email protected]>

.

Signed-off-by: Liang Huang <[email protected]>
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Apr 2, 2024
Copy link
Contributor

mergify bot commented Apr 2, 2024

@samhuang-z Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added the kind/enhancement Issues or changes related to enhancement label Apr 2, 2024
Copy link
Contributor

mergify bot commented Apr 2, 2024

@samhuang-z Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.90%. Comparing base (8b8a5b4) to head (0a39295).
Report is 2 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #31830      +/-   ##
==========================================
+ Coverage   80.62%   80.90%   +0.28%     
==========================================
  Files         973      973              
  Lines      138980   138980              
==========================================
+ Hits       112048   112445     +397     
+ Misses      23176    22778     -398     
- Partials     3756     3757       +1     

see 33 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Apr 2, 2024
Copy link
Contributor

@LoveEachDay LoveEachDay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@yanliang567
Copy link
Contributor

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LoveEachDay, samhuang-z, yanliang567

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 3c14c8a into milvus-io:2.4 Apr 3, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants