Rust client improvements #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
danenbm
force-pushed
the
danenbm/rust-client-improvements
branch
from
c55b0e4
to
1dfc8cb
Compare
danenbm
force-pushed
the
danenbm/rust-client-improvements
branch
from
fec913b
to
3b826a3
Compare
blockiosaurus
approved these changes
Jul 1, 2024
tonyboylehub
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
fetch_external_plugin_adapter_data()Account<BaseAssetV1>andAccount<BaseCollectionV1>.AssetandCollectiondeserialization functions, and move the required plugin deserializion into helper functions to reduce stack frame. Together these changes mitigate stack overflow when usingAssetandCollectiontypes.fetch_wrapped_external_plugin_adapter()as I used it forfetch_external_plugin_adapter_data(), but made it based on a helper to avoid double-deserialization infetch_external_plugin_adapter().Testing
fetch_external_plugin_adapter_data()totest_create_and_fetch_app_data.Account<BaseAssetV1>andAccount<BaseCollectionV1>works in an Anchor program.Asset::from_bytes()andCollection::from_bytes()could be used in an Anchor program where a largeAttributesplugin was previously causing stack overflow.