Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport Rust client improvements from jun-2024-feature-staging #158

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

danenbm
Copy link
Contributor

@danenbm danenbm commented Jul 2, 2024

Notes

  • Backport of 3 commits from Rust client improvements #155 to main.
  • Added Anchor trait implementations that enable deserializing in Anchor via Account<BaseAssetV1> and Account<BaseCollectionV1>.
  • Box the return types for Rust client Asset and Collection deserialization functions, and move the required plugin deserializion into helper functions to reduce stack frame. Together these changes mitigate stack overflow when using Asset and Collection types.

Testing

  • Validated Account<BaseAssetV1> and Account<BaseCollectionV1> works in an Anchor program.
  • Validated Asset::from_bytes() and Collection::from_bytes() works in an Anchor program.

Copy link

vercel bot commented Jul 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mpl-core-js-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2024 6:27am

@danenbm danenbm merged commit 749b256 into main Jul 3, 2024
10 checks passed
@danenbm danenbm deleted the danenbm/rust-client-impr-backport branch July 3, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants