Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect file extension setting for S3 destinations in Firehose provider #10651

Merged
merged 2 commits into from
May 22, 2024
Merged

Respect file extension setting for S3 destinations in Firehose provider #10651

merged 2 commits into from
May 22, 2024

Commits on May 22, 2024

  1. Respect file extension setting for S3 destinations in Firehose provider 

    The Firehose delivery stream implementation was not considering the file
extension setting when the target was defined as an S3 bucket. This fix
ensures that the specified file extension is appended to the S3 object's
key when writing data. The `_get_s3_object_path` method now accepts the
`file_extension` parameter to accommodate this enhancement.
    @ozgenbaris1 @pinzon
    ozgenbaris1 authored and pinzon committed May 22, 2024
    Configuration menu
    Copy the full SHA
    dd35352 View commit details
    Browse the repository at this point in the history

  2. make the test aws valid

    @pinzon
    pinzon committed May 22, 2024
    Configuration menu
    Copy the full SHA
    fcbccd3 View commit details
    Browse the repository at this point in the history