Respect file extension setting for S3 destinations in Firehose provider #10651
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The Firehose delivery stream implementation was not considering the file extension setting when the target was defined as an S3 bucket. This fix ensures that the specified file extension is appended to the S3 object's key when writing data. The
_get_s3_object_path
method now accepts thefile_extension
parameter to accommodate this enhancement.This change introduces support for file extensions by extracting the FileExtension parameter from the S3 destination description. Now, if a file extension is provided, it will be appended to the S3 object's key, ensuring that files are created with the correct extensions, improving flexibility for users relying on file extensions for downstream processing or identification of data within S3 buckets.
Motivation
resolves #10650