Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added features for May 2024 Embeddings Models #205

Merged
merged 19 commits into from
Jun 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
86 changes: 75 additions & 11 deletions libs/vertexai/langchain_google_vertexai/embeddings.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,53 @@ class GoogleEmbeddingModelType(str, Enum):
def _missing_(cls, value: Any) -> Optional["GoogleEmbeddingModelType"]:
if value.lower().startswith("text"):
return GoogleEmbeddingModelType.TEXT
elif "multimodalembedding" in value.lower():
if "multimodalembedding" in value.lower():
return GoogleEmbeddingModelType.MULTIMODAL
return None


class GoogleEmbeddingModelVersion(str, Enum):
EMBEDDINGS_JUNE_2023 = auto()
EMBEDDINGS_NOV_2023 = auto()
EMBEDDINGS_DEC_2023 = auto()
EMBEDDINGS_MAY_2024 = auto()

@classmethod
def _missing_(cls, value: Any) -> "GoogleEmbeddingModelVersion":
if "textembedding-gecko@001" in value.lower():
return GoogleEmbeddingModelVersion.EMBEDDINGS_JUNE_2023
if (
"textembedding-gecko@002" in value.lower()
or "textembedding-gecko-multilingual@001" in value.lower()
):
return GoogleEmbeddingModelVersion.EMBEDDINGS_NOV_2023
if "textembedding-gecko@003" in value.lower():
return GoogleEmbeddingModelVersion.EMBEDDINGS_DEC_2023
if (
"text-embedding-004" in value.lower()
or "text-multilingual-embedding-002" in value.lower()
or "text-embedding-preview-0409" in value.lower()
or "text-multilingual-embedding-preview-0409" in value.lower()
):
return GoogleEmbeddingModelVersion.EMBEDDINGS_MAY_2024

return GoogleEmbeddingModelVersion.EMBEDDINGS_JUNE_2023

@property
def task_type_supported(self) -> bool:
"""
Checks if the model generation supports task type.
"""
return self != GoogleEmbeddingModelVersion.EMBEDDINGS_JUNE_2023

@property
def output_dimensionality_supported(self) -> bool:
"""
Checks if the model generation supports output dimensionality.
"""
return self == GoogleEmbeddingModelVersion.EMBEDDINGS_MAY_2024


class VertexAIEmbeddings(_VertexAICommon, Embeddings):
"""Google Cloud VertexAI embedding models."""

Expand Down Expand Up @@ -106,9 +148,6 @@ def __init__(
self.instance["task_executor"] = ThreadPoolExecutor(
max_workers=request_parallelism
)
self.instance[
"embeddings_task_type_supported"
] = not self.client._endpoint_name.endswith("/textembedding-gecko@001")

retry_errors: List[Type[BaseException]] = [
ResourceExhausted,
Expand All @@ -127,6 +166,10 @@ def __init__(
def model_type(self) -> str:
return GoogleEmbeddingModelType(self.model_name)

@property
def model_version(self) -> GoogleEmbeddingModelVersion:
return GoogleEmbeddingModelVersion(self.model_name)

@staticmethod
def _split_by_punctuation(text: str) -> List[str]:
"""Splits a string by punctuation and whitespace characters."""
Expand Down Expand Up @@ -188,25 +231,29 @@ def _prepare_batches(texts: List[str], batch_size: int) -> List[List[str]]:
return batches

def _get_embeddings_with_retry(
self, texts: List[str], embeddings_type: Optional[str] = None
self,
texts: List[str],
embeddings_type: Optional[str] = None,
dimensions: Optional[int] = None,
) -> List[List[float]]:
"""Makes a Vertex AI model request with retry logic."""
with telemetry.tool_context_manager(self._user_agent):
if self.model_type == GoogleEmbeddingModelType.MULTIMODAL:
return self._get_multimodal_embeddings_with_retry(texts)
return self._get_multimodal_embeddings_with_retry(texts, dimensions)
return self._get_text_embeddings_with_retry(
texts, embeddings_type=embeddings_type
texts, embeddings_type=embeddings_type, output_dimensionality=dimensions
)

def _get_multimodal_embeddings_with_retry(
self, texts: List[str]
self, texts: List[str], dimensions: Optional[int] = None
) -> List[List[float]]:
tasks = []
for text in texts:
tasks.append(
self.instance["task_executor"].submit(
self.instance["get_embeddings_with_retry"],
contextual_text=text,
dimension=dimensions,
)
)
if len(tasks) > 0:
Expand All @@ -215,17 +262,25 @@ def _get_multimodal_embeddings_with_retry(
return embeddings

def _get_text_embeddings_with_retry(
self, texts: List[str], embeddings_type: Optional[str] = None
self,
texts: List[str],
embeddings_type: Optional[str] = None,
output_dimensionality: Optional[int] = None,
) -> List[List[float]]:
"""Makes a Vertex AI model request with retry logic."""

if embeddings_type and self.instance["embeddings_task_type_supported"]:
if embeddings_type and self.model_version.task_type_supported:
requests = [
TextEmbeddingInput(text=t, task_type=embeddings_type) for t in texts
]
else:
requests = texts
embeddings = self.instance["get_embeddings_with_retry"](requests)

kwargs = {}
if output_dimensionality and self.model_version.output_dimensionality_supported:
kwargs["output_dimensionality"] = output_dimensionality

embeddings = self.instance["get_embeddings_with_retry"](requests, **kwargs)
return [embedding.values for embedding in embeddings]

def _prepare_and_validate_batches(
Expand Down Expand Up @@ -310,8 +365,11 @@ def embed(
"SEMANTIC_SIMILARITY",
"CLASSIFICATION",
"CLUSTERING",
"QUESTION_ANSWERING",
"FACT_VERIFICATION",
]
] = None,
dimensions: Optional[int] = None,
) -> List[List[float]]:
"""Embed a list of strings.

Expand All @@ -330,6 +388,11 @@ def embed(
for Semantic Textual Similarity (STS).
CLASSIFICATION - Embeddings will be used for classification.
CLUSTERING - Embeddings will be used for clustering.
The following are only supported on preview models:
QUESTION_ANSWERING
FACT_VERIFICATION
dimensions: [int] optional. Output embeddings dimensions.
Only supported on preview models.

Returns:
List of embeddings, one for each text.
Expand All @@ -356,6 +419,7 @@ def embed(
self._get_embeddings_with_retry,
texts=batch,
embeddings_type=embeddings_task_type,
dimensions=dimensions,
)
)
if len(tasks) > 0:
Expand Down
20 changes: 20 additions & 0 deletions libs/vertexai/tests/integration_tests/test_embeddings.py
Original file line number Diff line number Diff line change
Expand Up @@ -94,3 +94,23 @@ def test_langchain_google_vertexai_multimodal_model() -> None:
embeddings_model = VertexAIEmbeddings(model_name="multimodalembedding@001")
assert isinstance(embeddings_model.client, MultiModalEmbeddingModel)
assert embeddings_model.model_type == GoogleEmbeddingModelType.MULTIMODAL


@pytest.mark.release
@pytest.mark.parametrize(
"model_name, embeddings_dim",
[("text-embedding-004", 768), ("text-multilingual-embedding-002", 768)],
)
def test_langchain_google_vertexai_embedding_with_output_dimensionality(
model_name: str, embeddings_dim: int
) -> None:
model = VertexAIEmbeddings(model_name)
output = model.embed(
texts=["foo bar"],
dimensions=embeddings_dim,
)
assert len(output) == 1
for embedding in output:
assert len(embedding) == embeddings_dim
assert model.model_name == model.client._model_id
assert model.model_name == model_name