feat: Added features for Preview Embeddings Models #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Output Dimensionality - Add additional embeddings types
|
could you extend an integration test, please? |
lkuligin
reviewed
May 4, 2024
| @@ -109,6 +109,9 @@ def __init__( | |||
| self.instance[ | |||
| "embeddings_task_type_supported" | |||
| ] = not self.client._endpoint_name.endswith("/textembedding-gecko@001") | |||
| self.instance["dimensionality_supported"] = self.client._endpoint_name.endswith( | |||
There was a problem hiding this comment.
could you move this logic to _utils, please, so that we have all the logic determening model's behaviour at least at one place (and we should introduct model family or smth like this).
There was a problem hiding this comment.
I've added ModelFamily notion, let's use it, please.
lkuligin
reviewed
May 11, 2024
| self, | ||
| texts: List[str], | ||
| embeddings_type: Optional[str] = None, | ||
| dimensions: Optional[int] = None, |
There was a problem hiding this comment.
can we stick to the argument's naming the same as Vertex uses, please? i.e., output_dimensionality instead of dimensions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://cloud.google.com/vertex-ai/generative-ai/docs/embeddings/get-text-embeddings#latest_models