Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add podAnnotation to medusa operator and reaper operator #1449

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add podAnnotation to medusa operator and reaper operator #1449

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2f90aff
Add podAnnotation to medusa operator and reaper operator
omygod613 Jul 16, 2022
a826d98
Update changelog
omygod613 Jul 16, 2022
6874d3d
Move podAnnotations under annotations
omygod613 Jul 16, 2022
a5d095d
Narrow the variable scope
omygod613 Jul 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions charts/medusa-operator/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ spec:
template:
metadata:
labels: {{- include "k8ssandra-common.labels" . | indent 8 }}
{{- with .Values.podAnnotations }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't .podAnnotations be under annotations?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsanda Could you check again? I updated some commits based on your comments.

annotations:
{{- toYaml . | nindent 8 }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't the variable scope you want. It needs to be more narrow.

{{- end }}
spec:
securityContext: {{- toYaml .Values.podSecurityContext | nindent 8 }}
serviceAccountName: {{ include "k8ssandra-common.serviceAccountName" . }}
Expand Down
4 changes: 4 additions & 0 deletions charts/reaper-operator/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ spec:
template:
metadata:
labels: {{- include "k8ssandra-common.labels" . | indent 8 }}
{{- with .Values.podAnnotations }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as comments for medusa-operator chart.

annotations:
{{- toYaml . | nindent 8 }}
{{- end }}
spec:
serviceAccountName: {{ include "k8ssandra-common.serviceAccountName" . }}
securityContext: {{- toYaml .Values.podSecurityContext | nindent 8 }}
Expand Down